From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4442F1FF184 for ; Thu, 20 Nov 2025 14:21:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 22EB68A83; Thu, 20 Nov 2025 14:22:00 +0100 (CET) Date: Thu, 20 Nov 2025 14:21:53 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20251120101742.24843-1-f.ebner@proxmox.com> In-Reply-To: <20251120101742.24843-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1763644497.6m8gy24914.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763644885472 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 storage] lvm plugin: fix locking for rollback when using CLI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" T24gTm92ZW1iZXIgMjAsIDIwMjUgMTE6MTcgYW0sIEZpb25hIEVibmVyIHdyb3RlOgo+IERvaW5n IGEgcm9sbGJhY2sgdmlhIENMSSBvbiBhbiBMVk0gc3RvcmFnZSB3aXRoICdzYWZlcmVtb3ZlJyBh bmQKPiAnc25hcHNob3QtYXMtdm9sdW1lLWNoYWluJyB3b3VsZCBydW4gaW50byBhIGxvY2tpbmcg aXNzdWUsIGJlY2F1c2UKPiB0aGUgZm9ya2VkIHplcm8tb3V0IHdvcmtlciB3b3VsZCB0cnkgdG8g YWNxdWlyZSB0aGUgbG9jayB3aGlsZSB0aGUKPiBtYWluIENMSSB0YXNrIGlzIHN0aWxsIGluc2lk ZSB0aGUgbG9ja2VkIHNlY3Rpb24gZm9yCj4gdm9sdW1lX3NuYXBzaG90X3JvbGxiYWNrX2xvY2tl ZCgpLiBUaGUgc2FtZSBpc3N1ZSBkb2VzIG5vdCBoYXBwZW4gd2hlbgo+IHRoZSByb2xsYmFjayBp cyBkb25lIHZpYSBVSS4gVGhlIHJlYXNvbiBmb3IgdGhpcyBjYW4gYmUgZm91bmQgaW4gdGhlCj4g bm90ZSByZWdhcmRpbmcgZm9ya193b3JrZXIoKToKPiAKPj4gd2Ugc2ltdWxhdGUgcnVubmluZyBp biBmb3JlZ3JvdW5kIGlmICgkc2VsZi0+e3R5cGV9IGVxICdjbGknKQo+IAo+IFNvIHRoZSB3b3Jr ZXIgd2lsbCBiZSBhd2FpdGVkIHN5bmNocm9ub3VzbHkgaW4gQ0xJIGNvbnRleHQsIHJlc3VsdGlu Zwo+IGluIHRoZSBkZWFkbG9jaywgd2hpbGUgdmlhIEFQSS9VSSwgdGhlIG1haW4gdGFzayB3b3Vs ZCBtb3ZlIG9uIGFuZAo+IHJlbGVhc2UgdGhlIGxvY2sgYWxsb3dpbmcgdGhlIHplcm8tb3V0IHdv cmtlciB0byBhY3F1aXJlIGl0Lgo+IAo+IEF2b2lkIGRvaW5nIGZvcmtfY2xlYW51cF93b3JrZXIo KSBpbnNpZGUgdGhlIGxvY2tlZCBzZWN0aW9uIHRvIGF2b2lkCj4gdGhlIGlzc3VlLgo+IAo+IEZp eGVzOiA4ZWFiY2M3ICgibHZtIHBsdWdpbjogc25hcHNob3QtYXMtdm9sdW1lLWNoYWluOiB1c2Ug bG9ja2luZyBmb3Igc25hcHNob3Qgb3BlcmF0aW9ucyIpCj4gU2lnbmVkLW9mZi1ieTogRmlvbmEg RWJuZXIgPGYuZWJuZXJAcHJveG1veC5jb20+Cj4gLS0tCj4gCj4gQ2hhbmdlcyBpbiB2MjoKPiAq IEJldHRlciBleHBsYW5hdGlvbiBpbiBjb21taXQgbWVzc2FnZS4KPiAqIEFsc28gc3Bhd24gY2xl YW51cCB3b3JrZXIgaW4gZXJyb3Igc2NlbmFyaW8gbGlrZSBiZWZvcmUgdGhlIHBhdGNoLgo+IAo+ ICBzcmMvUFZFL1N0b3JhZ2UvTFZNUGx1Z2luLnBtIHwgNDMgKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAxNyBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvc3JjL1BWRS9TdG9yYWdlL0xWTVBsdWdpbi5w bSBiL3NyYy9QVkUvU3RvcmFnZS9MVk1QbHVnaW4ucG0KPiBpbmRleCA5N2Y3YmY0Li4xMDJjZjIy IDEwMDY0NAo+IC0tLSBhL3NyYy9QVkUvU3RvcmFnZS9MVk1QbHVnaW4ucG0KPiArKysgYi9zcmMv UFZFL1N0b3JhZ2UvTFZNUGx1Z2luLnBtCj4gQEAgLTExMTcsMjMgKzExMTcsMTcgQEAgc3ViIHZv bHVtZV9yb2xsYmFja19pc19wb3NzaWJsZSB7Cj4gIH0KPiAgCj4gIG15IHN1YiB2b2x1bWVfc25h cHNob3Rfcm9sbGJhY2tfbG9ja2VkIHsKPiAtICAgIG15ICgkY2xhc3MsICRzY2ZnLCAkc3RvcmVp ZCwgJHZvbG5hbWUsICRzbmFwKSA9IEBfOwo+ICsgICAgbXkgKCRjbGFzcywgJHNjZmcsICRzdG9y ZWlkLCAkdm9sbmFtZSwgJHNuYXAsICRjbGVhbnVwX3dvcmtlcikgPSBAXzsKPiAgCj4gICAgICBt eSAkZm9ybWF0ID0gKCRjbGFzcy0+cGFyc2Vfdm9sbmFtZSgkdm9sbmFtZSkpWzZdOwo+ICAKPiAg ICAgIGRpZSAiY2FuJ3Qgcm9sbGJhY2sgc25hcHNob3QgZm9yICckZm9ybWF0JyB2b2x1bWVcbiIg aWYgJGZvcm1hdCBuZSAncWNvdzInOwo+ICAKPiAtICAgIG15ICRjbGVhbnVwX3dvcmtlciA9IGV2 YWwgeyBmcmVlX3NuYXBfaW1hZ2UoJGNsYXNzLCAkc3RvcmVpZCwgJHNjZmcsICR2b2xuYW1lLCAn Y3VycmVudCcpOyB9Owo+ICsgICAgJGNsZWFudXBfd29ya2VyLT4kKiA9IGV2YWwgeyBmcmVlX3Nu YXBfaW1hZ2UoJGNsYXNzLCAkc3RvcmVpZCwgJHNjZmcsICR2b2xuYW1lLCAnY3VycmVudCcpOyB9 Owo+ICAgICAgZGllICJlcnJvciBkZWxldGluZyBzbmFwc2hvdCAkc25hcCAkQFxuIiBpZiAkQDsK PiAgCj4gICAgICBldmFsIHsgYWxsb2Nfc25hcF9pbWFnZSgkY2xhc3MsICRzdG9yZWlkLCAkc2Nm ZywgJHZvbG5hbWUsICRzbmFwKSB9Owo+IC0gICAgbXkgJGFsbG9jX2VyciA9ICRAOwo+IC0KPiAt ICAgIGZvcmtfY2xlYW51cF93b3JrZXIoJGNsZWFudXBfd29ya2VyKTsKPiAtCj4gLSAgICBpZiAo JGFsbG9jX2Vycikgewo+IC0gICAgICAgIGRpZSAiY2FuJ3QgYWxsb2NhdGUgbmV3IHZvbHVtZSAk dm9sbmFtZTogJGFsbG9jX2VyclxuIjsKPiAtICAgIH0KPiArICAgIGRpZSAiY2FuJ3QgYWxsb2Nh dGUgbmV3IHZvbHVtZSAkdm9sbmFtZTogJEBcbiIgaWYgJEA7Cj4gIAo+ICAgICAgcmV0dXJuIHVu ZGVmOwo+ICB9Cj4gQEAgLTExNDEsMTQgKzExMzUsMjkgQEAgbXkgc3ViIHZvbHVtZV9zbmFwc2hv dF9yb2xsYmFja19sb2NrZWQgewo+ICBzdWIgdm9sdW1lX3NuYXBzaG90X3JvbGxiYWNrIHsKPiAg ICAgIG15ICgkY2xhc3MsICRzY2ZnLCAkc3RvcmVpZCwgJHZvbG5hbWUsICRzbmFwKSA9IEBfOwo+ ICAKPiAtICAgIHJldHVybiAkY2xhc3MtPmNsdXN0ZXJfbG9ja19zdG9yYWdlKAo+IC0gICAgICAg ICRzdG9yZWlkLAo+IC0gICAgICAgICRzY2ZnLT57c2hhcmVkfSwKPiAtICAgICAgICB1bmRlZiwK PiAtICAgICAgICBzdWIgewo+IC0gICAgICAgICAgICByZXR1cm4gdm9sdW1lX3NuYXBzaG90X3Jv bGxiYWNrX2xvY2tlZCgkY2xhc3MsICRzY2ZnLCAkc3RvcmVpZCwgJHZvbG5hbWUsICRzbmFwKTsK PiAtICAgICAgICB9LAo+IC0gICAgKTsKPiArICAgIG15ICRjbGVhbnVwX3dvcmtlcjsKPiArCj4g KyAgICBldmFsIHsKPiArICAgICAgICAkY2xhc3MtPmNsdXN0ZXJfbG9ja19zdG9yYWdlKAo+ICsg ICAgICAgICAgICAkc3RvcmVpZCwKPiArICAgICAgICAgICAgJHNjZmctPntzaGFyZWR9LAo+ICsg ICAgICAgICAgICB1bmRlZiwKPiArICAgICAgICAgICAgc3ViIHsKPiArICAgICAgICAgICAgICAg IHZvbHVtZV9zbmFwc2hvdF9yb2xsYmFja19sb2NrZWQoCj4gKyAgICAgICAgICAgICAgICAgICAg JGNsYXNzLCAkc2NmZywgJHN0b3JlaWQsICR2b2xuYW1lLCAkc25hcCwgXCRjbGVhbnVwX3dvcmtl ciwKPiArICAgICAgICAgICAgICAgICk7Cj4gKyAgICAgICAgICAgIH0sCj4gKyAgICAgICAgKTsK PiArICAgIH07Cj4gKyAgICBteSAkZXJyID0gJEA7Cj4gKwo+ICsgICAgIyBTcGF3biBvdXRzaWRl IG9mIHRoZSBsb2NrZWQgc2VjdGlvbiwgYmVjYXVzZSB3aXRoICdzYWZlcmVtb3ZlJywgdGhlIGNs ZWFudXAgd29ya2VyIGFsc28gbmVlZHMKPiArICAgICMgdG8gb2J0YWluIHRoZSBsb2NrLCBhbmQg aW4gQ0xJIGNvbnRleHQsIGl0IHdpbGwgYmUgYXdhaXRlZCBzeW5jaHJvbm91c2x5LCBzZWUgZm9y a193b3JrZXIoKS4KPiArICAgIGZvcmtfY2xlYW51cF93b3JrZXIoJGNsZWFudXBfd29ya2VyKTsK CkkgbWVhbiwgdGhpcyBqdXN0IHdvcmtlZCBiZWNhdXNlIHRoZSBmb3JrZWQgY2xlYW51cCBzdWIg d2FpdGVkIGxvbmcKZW5vdWdoIGJ5IGNoYW5jZSBmb3IgdGhlIGxvY2svYmVmb3JlIGFjcXVpcmlu ZyB0aGUgbG9jayB0byBhbGxvdyB0aGUKcGFyZW50IHRvIHJlbGVhc2UgaXQgaW4gdGhlIG5vbi1D TEkgY2FzZSwgcmlnaHQ/IGkuZS4sIGl0IHdhcyBzdGlsbAp3cm9uZywgYmVjYXVzZSB2b2x1bWVf c25hcHNob3Rfcm9sbGJhY2tfbG9ja2VkIG1pZ2h0IGhhdmUgZG9uZSBtb3JlIHdvcmsKYWZ0ZXIg Zm9ya2luZyB0aGUgY2xlYW51cCB3b3JrZXIgd2hpbGUgc3RpbGwgaG9sZGluZyB0aGUgbG9jay4u CgphbGwgdGhlIG90aGVyIGNvZGUgcGF0aHMgaGVyZSBoYXZlIHRoaXMgcGF0dGVybjoKCm15ICRj bGVhbnVwX3dvcmtlciA9IGV2YWwgeyBsb2NrIGFuZCBkbyBzb21ldGhpbmcgfTsKZm9ya19jbGVh bnVwX3dvcmtlcigkY2xlYW51cF93b3JrZXIpCgp3aGljaCBpcyBleGFjdGx5IHdoYXQgdGhpcyBw YXRjaCBzd2l0Y2hlcyB0bywgc28gY29uc2lkZXIgdGhpcwoKUmV2aWV3ZWQtYnk6IEZhYmlhbiBH csO8bmJpY2hsZXIgPGYuZ3J1ZW5iaWNobGVyQHByb3htb3guY29tPgoKPiArCj4gKyAgICBkaWUg JGVyciBpZiAkZXJyOwo+ICsKPiArICAgIHJldHVybjsKPiAgfQo+ICAKPiAgc3ViIHZvbHVtZV9z bmFwc2hvdF9kZWxldGUgewo+IC0tIAo+IDIuNDcuMwo+IAo+IAo+IAo+IF9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gcHZlLWRldmVsIG1haWxpbmcgbGlz dAo+IHB2ZS1kZXZlbEBsaXN0cy5wcm94bW94LmNvbQo+IGh0dHBzOi8vbGlzdHMucHJveG1veC5j b20vY2dpLWJpbi9tYWlsbWFuL2xpc3RpbmZvL3B2ZS1kZXZlbAo+IAo+IAo+IAoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCnB2ZS1kZXZlbCBtYWlsaW5n IGxpc3QKcHZlLWRldmVsQGxpc3RzLnByb3htb3guY29tCmh0dHBzOi8vbGlzdHMucHJveG1veC5j b20vY2dpLWJpbi9tYWlsbWFuL2xpc3RpbmZvL3B2ZS1kZXZlbAo=