[pve-devel] [PATCH ha-manager/manager/proxmox-widget-toolkit 0/3] remove

[pve-devel] [PATCH ha-manager/manager/proxmox-widget-toolkit 0/3] remove

[Michael Köppl]

Even though groups have been replaced with rules in PVE 9, the guest
summary still displayed "Groups: none" for VMs and CTs. This patch
series removes this information from the HA status information and also
removes the remnants of it in the widget-toolkit and ha-manager.

The patch series does not add information about rules as a replacement
for the following reasons:
- There is no 1:1 mapping of resources to groups anymore, so a resource
  could potentially have many rules, cluttering the summary page
- Finding the rules that reference the given resource adds more
  complexity compared to finding the group for information that can be
  be viewed in a less cluttered manner on the rules page.

pve-manager:

Michael Köppl (1):
  ui: ha: remove group info from HA status string in guest status view

 www/manager6/Utils.js | 3 ---
 1 file changed, 3 deletions(-)


proxmox-widget-toolkit:

Michael Köppl (1):
  remove unused groupText mapping

 src/Utils.js | 1 -
 1 file changed, 1 deletion(-)


pve-ha-manager:

Michael Köppl (1):
  config: remove groups field from service status data

 src/PVE/HA/Config.pm | 1 -
 1 file changed, 1 deletion(-)


Summary over all repositories:
  3 files changed, 0 insertions(+), 5 deletions(-)

-- 
Generated by git-murpp 0.8.0


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 1/1] ui: ha: remove group info from HA status string in guest status view

[Michael Köppl]

Groups have been deprecated in favor of rules, so this information
should no longer be displayed. Since there is no longer a 1:1 mapping of
resources to groups and resources could be in many rules, displaying
information about the rules in this view would clutter the guest status
view. In addition, finding the rules of which the resource is a part of
adds a lot more complexity than getting the group did. Thus, the
information is omitted from the status text altogether.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 www/manager6/Utils.js | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index c48ee0b25..93e026b43 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1014,9 +1014,6 @@ Ext.define('PVE.Utils', {
 
             if (value.managed) {
                 text = value.state || Proxmox.Utils.noneText;
-
-                text += ', ' + Proxmox.Utils.groupText + ': ';
-                text += value.group || Proxmox.Utils.noneText;
             }
 
             return text;
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH widget-toolkit 1/1] remove unused groupText mapping

[Michael Köppl]

Groups have been replaced by rules. Since the guest status view no
longer displays information about rules, this mapping can also be
removed.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 src/Utils.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/Utils.js b/src/Utils.js
index a0c6ca5..beb9df2 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -60,7 +60,6 @@ Ext.define('Proxmox.Utils', {
         usedText: gettext('Used'),
         directoryText: gettext('Directory'),
         stateText: gettext('State'),
-        groupText: gettext('Group'),
 
         language_map: {
             //language map is sorted alphabetically by iso 639-1
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH ha-manager 1/1] config: remove groups field from service status data

[Michael Köppl]

Groups have been replaced by rules. Since rules are no longer displayed
as part of the service status and fetching the relevant rules would add
more complexity compared to getting the group, this information is
omitted altogether.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 src/PVE/HA/Config.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/PVE/HA/Config.pm b/src/PVE/HA/Config.pm
index 301c62f..384999b 100644
--- a/src/PVE/HA/Config.pm
+++ b/src/PVE/HA/Config.pm
@@ -473,7 +473,6 @@ sub get_service_status {
         my $manager_status = cfs_read_file($manager_status_filename);
 
         $status->{managed} = 1;
-        $status->{group} = $conf->{ids}->{$sid}->{group};
         $status->{state} = $manager_status->{service_status}->{$sid}->{state};
     }
 
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH ha-manager/manager/proxmox-widget-toolkit 0/3] remove

[Daniel Kral]

On Fri Sep 19, 2025 at 4:06 PM CEST, Michael Köppl wrote:
> Even though groups have been replaced with rules in PVE 9, the guest
> summary still displayed "Groups: none" for VMs and CTs. This patch
> series removes this information from the HA status information and also
> removes the remnants of it in the widget-toolkit and ha-manager.
>
> The patch series does not add information about rules as a replacement
> for the following reasons:
> - There is no 1:1 mapping of resources to groups anymore, so a resource
>   could potentially have many rules, cluttering the summary page
> - Finding the rules that reference the given resource adds more
>   complexity compared to finding the group for information that can be
>   be viewed in a less cluttered manner on the rules page.

Thanks!

The changes look good to me.

Just to link these here, there were two community forum posts [0] and
[1], which added some more viewpoints how HA groups are/were used and
what could still be improved for the HA rules.

The pain points were primarily that users could add/remove HA resources
to/from HA groups directly through the VM/CT in the web interface under
More > Manage HA and then select the assigned HA group there, instead of
going to the Datacenter > HA tab.

For HA node affinity rules, the former isn't possible anymore and the
main workflow is to add the HA resources and then add them to a node
affinity rule in bulk there. I'm not sure how we could improve that yet.

[0] https://forum.proxmox.com/threads/172190/

Anyway:

Reviewed-by: Daniel Kral <d.kral@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH ha-manager/manager/proxmox-widget-toolkit 0/3] remove

[Michael Köppl]

On Fri Sep 19, 2025 at 4:41 PM CEST, Daniel Kral wrote:
> Just to link these here, there were two community forum posts [0] and
> [1], which added some more viewpoints how HA groups are/were used and
> what could still be improved for the HA rules.
>
> The pain points were primarily that users could add/remove HA resources
> to/from HA groups directly through the VM/CT in the web interface under
> More > Manage HA and then select the assigned HA group there, instead of
> going to the Datacenter > HA tab.
>
> For HA node affinity rules, the former isn't possible anymore and the
> main workflow is to add the HA resources and then add them to a node
> affinity rule in bulk there. I'm not sure how we could improve that yet.
>
> [0] https://forum.proxmox.com/threads/172190/

[1] https://forum.proxmox.com/threads/171427/


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH ha-manager/manager/proxmox-widget-toolkit 0/3] remove

[Friedrich Weber]

On 19/09/2025 16:06, Michael Köppl wrote:
> Even though groups have been replaced with rules in PVE 9, the guest
> summary still displayed "Groups: none" for VMs and CTs. This patch
> series removes this information from the HA status information and also
> removes the remnants of it in the widget-toolkit and ha-manager.

Ping -- this also came up during a training.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH widget-toolkit 1/1] remove unused groupText mapping

[Thomas Lamprecht]

On Fri, 19 Sep 2025 16:06:19 +0200, Michael Köppl wrote:
> Groups have been replaced by rules. Since the guest status view no
> longer displays information about rules, this mapping can also be
> removed.
> 
> 

Applied, thanks!

[1/1] remove unused groupText mapping
      commit: 404111a377e1d595d84e470a747c6d1d738cb306


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager 1/1] ui: ha: remove group info from HA status string in guest status view

[Thomas Lamprecht]

On Fri, 19 Sep 2025 16:06:18 +0200, Michael Köppl wrote:
> Groups have been deprecated in favor of rules, so this information
> should no longer be displayed. Since there is no longer a 1:1 mapping of
> resources to groups and resources could be in many rules, displaying
> information about the rules in this view would clutter the guest status
> view. In addition, finding the rules of which the resource is a part of
> adds a lot more complexity than getting the group did. Thus, the
> information is omitted from the status text altogether.
> 
> [...]

Applied, thanks!

Getting all rules a guest is part of would be nice to have in the future,
but that would probably then be displayed in a dedicated window that opens,
e.g. similar to the VM IP view for when QGA is active.
In the status we could show the count of rules or if it's parts of rules at
all, but would only do that if it's cheap to gather.

[1/1] ui: ha: remove group info from HA status string in guest status view
      commit: fec66c2823927fa38b2376e0ac6c0333e41a3fb9


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH ha-manager 1/1] config: remove groups field from service status data

[Thomas Lamprecht]

On Fri, 19 Sep 2025 16:06:20 +0200, Michael Köppl wrote:
> Groups have been replaced by rules. Since rules are no longer displayed
> as part of the service status and fetching the relevant rules would add
> more complexity compared to getting the group, this information is
> omitted altogether.
> 
> 

Applied, thanks!

[1/1] config: remove groups field from service status data
      commit: 86c4db163efa1144acab79f3420ab0c4ecd21a90


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel