Re: [pve-devel] [PATCH manager] api2 tools: rrd data: prefer new-format keys over old-format keys

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On Tue, 21 Oct 2025 17:50:27 +0200, Friedrich Weber wrote:
> This fixes an issue where on a fresh Proxmox VE 9 cluster, the status
> of the first VM/container would not be updated in the resource tree
> for the first 5 minutes after creation. For example, starting the
> newly created guest after the first pvestatd status update would not
> update the state to "running" for 5 minutes.
> 
> The reason is that pvestatd, when broadcasting RRD data, checks for
> existence of /var/lib/rrdcached/db/pve-vm-9.0/ to decide whether to
> send RRD data with new-format (pve-vm-9.0/) or old-format (pve2.3-vm/)
> keys. The directory does not exist on nodes of a fresh cluster without
> guests, so pvestatd falls back to sending an old-format key. pmxcfs,
> upon receiving the key, creates the directory, so on the next pvestatd
> status update, pvestatd will send out new-format keys. But until the
> entry with the old-format key expires (after 5 minutes), both the
> new-format and the old-format key exist in the RRD data. Currently, if
> both keys are present, get_rrd_key will return the old-format key,
> meaning that any status updates with the new-format key are not
> registered. In order to fix this, prefer the new-format key if it is
> present.
> 
> [...]

As this is w.r.t. choosing what existing data one should use it definitively
makes sense to prefer the new format, at least with recent changes to how we
(do not) upgrade the old data anymore and start directly with the new format.

Applied, thanks!

[1/1] api2 tools: rrd data: prefer new-format keys over old-format keys
      commit: 0ffad1d59611d1bf26fe99dbdc9a89fb49006ea6


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel