public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer 0/6] interface name pinning followups
Date: Thu, 13 Nov 2025 21:00:40 +0100	[thread overview]
Message-ID: <176306403669.2651046.8451157541738097242.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251113135023.1038305-1-c.heiss@proxmox.com>

On Thu, 13 Nov 2025 14:49:48 +0100, Christoph Heiss wrote:
> Some small followups for the initial name pinning support [0].
> 
> First and foremost makes the interface name checks a bit stricter, to
> comply with our `pve-iface` schema - as reported by Stoiko [1]. Thanks!
> 
> Patch #4 & #5 exclude non-physical interfaces from being shown in the
> pinning dialog in the GUI and TUI, respectively. While this does change
> anything for normal bare-metal installation, it is a) a bit of
> future-proofing and b) improves developer/testing experience a bit, as
> these interfaces should never be available for pinning anyway.
> 
> [...]

Applied, thanks!

[1/6] sys: net: pinning: make interface name checks stricter
      commit: 2033a3576fae1f684024710541508f16b04d72de
[2/6] common: pinning: make interface name checks stricter
      commit: aa0ddcdbff34f8bd3d16e017df3ef160e2e1cdd5
[3/6] test: validate-link-pin-map: give all tests a name
      commit: 24f69569adcec258edc74190b111e71858e3ca4d
[4/6] gui: network: only display pinnable devices in pinning options dialog
      commit: 3520f0dc1941e06dd4b1192007a3e0e97c7c8f0e
[5/6] tui: network: only display pinnable devices in pinning options dialog
      commit: 32b2ea3bb230c22008f7f3af6c9ab7c433069561
[6/6] tree-wide: run cargo fmt
      commit: d505f71b3c5da129880ca9b15e95e0946d9933cb


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-11-13 20:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 13:49 [pve-devel] " Christoph Heiss
2025-11-13 13:49 ` [pve-devel] [PATCH installer 1/6] sys: net: pinning: make interface name checks stricter Christoph Heiss
2025-11-13 13:49 ` [pve-devel] [PATCH installer 2/6] common: " Christoph Heiss
2025-11-13 13:49 ` [pve-devel] [PATCH installer 3/6] test: validate-link-pin-map: give all tests a name Christoph Heiss
2025-11-13 13:49 ` [pve-devel] [PATCH installer 4/6] gui: network: only display pinnable devices in pinning options dialog Christoph Heiss
2025-11-13 13:49 ` [pve-devel] [PATCH installer 5/6] tui: " Christoph Heiss
2025-11-13 13:49 ` [pve-devel] [PATCH installer 6/6] tree-wide: run cargo fmt Christoph Heiss
2025-11-13 20:00 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176306403669.2651046.8451157541738097242.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal