public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH docs 2/2] pve-storage-lvm: add saferemove-stepsize
       [not found] <20251029132745.3127244-1-alwin@antreich.com>
@ 2025-10-29 13:27 ` Alwin Antreich via pve-devel
  2025-11-10 10:09   ` Alwin Antreich via pve-devel
  2025-11-11 15:34   ` [pve-devel] applied: " Fiona Ebner
  0 siblings, 2 replies; 3+ messages in thread
From: Alwin Antreich via pve-devel @ 2025-10-29 13:27 UTC (permalink / raw)
  To: pve-devel; +Cc: Alwin Antreich

[-- Attachment #1: Type: message/rfc822, Size: 4156 bytes --]

From: Alwin Antreich <alwin@antreich.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH docs 2/2] pve-storage-lvm: add saferemove-stepsize
Date: Wed, 29 Oct 2025 14:27:45 +0100
Message-ID: <20251029132745.3127244-2-alwin@antreich.com>

and mention the different tools used for saferemove to choose the right
option for configuration.

Signed-off-by: Alwin Antreich <alwin@antreich.com>
---

I've added th is patch in response to:
https://lore.proxmox.com/all/mailman.253.1761222252.362.pve-devel@lists.proxmox.com/T/#u

 pve-storage-lvm.adoc | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/pve-storage-lvm.adoc b/pve-storage-lvm.adoc
index 527c732..5dd034e 100644
--- a/pve-storage-lvm.adoc
+++ b/pve-storage-lvm.adoc
@@ -43,6 +43,15 @@ When removing a volume, this makes sure that all data gets erased and cannot be
 accessed by other LVs created later (which happen to be assigned the same
 physical extents). This is a costly operation, but may be required as a security
 measure in certain environments.
++
+Storage devices that support the write zeroes operation will use blockdiscard
+to zero blocks. Otherwise, a fallback to cstream is performed.
+
+`saferemove-stepsize`::
+
+Wipe step size in MiB (`blockdiscard -p` paramater value), capped to the maximum
+step size supported by the underlying storage. Up to 32 MiB (maximum) by
+default.
 
 `saferemove_throughput`::
 
-- 
2.39.5




[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH docs 2/2] pve-storage-lvm: add saferemove-stepsize
  2025-10-29 13:27 ` [pve-devel] [PATCH docs 2/2] pve-storage-lvm: add saferemove-stepsize Alwin Antreich via pve-devel
@ 2025-11-10 10:09   ` Alwin Antreich via pve-devel
  2025-11-11 15:34   ` [pve-devel] applied: " Fiona Ebner
  1 sibling, 0 replies; 3+ messages in thread
From: Alwin Antreich via pve-devel @ 2025-11-10 10:09 UTC (permalink / raw)
  To: Proxmox VE development discussion; +Cc: Alwin Antreich

[-- Attachment #1: Type: message/rfc822, Size: 3759 bytes --]

From: "Alwin Antreich" <alwin@antreich.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH docs 2/2] pve-storage-lvm: add saferemove-stepsize
Date: Mon, 10 Nov 2025 10:09:09 +0000
Message-ID: <08af75705ecef4a3f1638db4487d34b658d97def@antreich.com>

Did anyone have a chance to look at it? Ty



October 29, 2025 at 2:27 PM, "Alwin Antreich via pve-devel" <pve-devel@lists.proxmox.com mailto:pve-devel@lists.proxmox.com?to=%22Alwin%20Antreich%20via%20pve-devel%22%20%3Cpve-devel%40lists.proxmox.com%3E > wrote:


> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com mailto:pve-devel@lists.proxmox.com 
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH docs 2/2] pve-storage-lvm: add saferemove-stepsize
  2025-10-29 13:27 ` [pve-devel] [PATCH docs 2/2] pve-storage-lvm: add saferemove-stepsize Alwin Antreich via pve-devel
  2025-11-10 10:09   ` Alwin Antreich via pve-devel
@ 2025-11-11 15:34   ` Fiona Ebner
  1 sibling, 0 replies; 3+ messages in thread
From: Fiona Ebner @ 2025-11-11 15:34 UTC (permalink / raw)
  To: Alwin Antreich via pve-devel

On Wed, 29 Oct 2025 14:27:45 +0100, Alwin Antreich via pve-devel wrote:
> and mention the different tools used for saferemove to choose the right
> option for configuration.

Applied, thanks! I fixed up the command name
'blockdiscard -> blkdiscard' and added quotes around "write zeroes" to
emphasize that it's the name of the special operation.

[2/2] pve-storage-lvm: add saferemove-stepsize
      commit: 17a22102e3149ca4c701cc5e74689bcd9c7eff49


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-11 15:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20251029132745.3127244-1-alwin@antreich.com>
2025-10-29 13:27 ` [pve-devel] [PATCH docs 2/2] pve-storage-lvm: add saferemove-stepsize Alwin Antreich via pve-devel
2025-11-10 10:09   ` Alwin Antreich via pve-devel
2025-11-11 15:34   ` [pve-devel] applied: " Fiona Ebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal