From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E403A1FF15C for ; Fri, 3 Oct 2025 13:43:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B51BC2501; Fri, 3 Oct 2025 13:43:12 +0200 (CEST) Date: Fri, 03 Oct 2025 13:42:35 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20250929122529.90484-1-f.ebner@proxmox.com> <20250929122529.90484-4-f.ebner@proxmox.com> In-Reply-To: <20250929122529.90484-4-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1759491643.eojtfsgzb2.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759491734047 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 3/3] migration: conntrack: avoid crash when dbus-vmstate object cannot be added (quickly enough) X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On September 29, 2025 2:24 pm, Fiona Ebner wrote: > As reported in the community forum [0], it might happen that the > dbus-vmstate object is not added (quickly enough) to the target QEMU > instance, before the migration state is loaded. This would result in > a crash of the target instance: > >> kvm: Unknown savevm section or instance 'dbus-vmstate/dbus-vmstate' >> 0. Make sure that your current VM setup matches your saved VM setup, >> including any hotplugged devices >> kvm: load of migration failed: Invalid argument > > This is after the configuration is already moved and thus there also > is no source instance running anymore. > > Make sure that the qemu_add_dbus_vmstate() function only returns > success when the object is successfully added. > > [0]: https://forum.proxmox.com/threads/172588/ > > Signed-off-by: Fiona Ebner > --- > src/PVE/QemuServer/DBusVMState.pm | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/src/PVE/QemuServer/DBusVMState.pm b/src/PVE/QemuServer/DBusVMState.pm > index a72d6dd2..354602a7 100644 > --- a/src/PVE/QemuServer/DBusVMState.pm > +++ b/src/PVE/QemuServer/DBusVMState.pm > @@ -11,6 +11,7 @@ use PVE::Systemd; > use PVE::Tools; > > use PVE::QemuServer::Helpers; > +use PVE::QemuServer::Monitor qw(mon_cmd); > > use constant { > DBUS_VMSTATE_EXE => '/usr/libexec/qemu-server/dbus-vmstate', > @@ -59,6 +60,15 @@ sub qemu_add_dbus_vmstate { > if (my $err = $@) { > die "failed to start DBus VMState service for VM $vmid: $err\n"; > } > + > + # Need to wait for the object to be added by the started service. > + for (my $i = 0; $i < 5; $i++) { > + my $qom_list = mon_cmd($vmid, 'qom-list', path => '/objects'); > + return if grep { $_->{name} eq 'pve-vmstate' } $qom_list->@*; > + sleep 1; > + } > + > + die "timeout waiting for pve-vmstate object to show up\n"; wouldn't this be better handled by making the service started here type=notify? > } > > # Stops the dbus-vmstate helper D-Bus service daemon and removes the associated > -- > 2.47.3 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel