From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1F8211FF15C for ; Fri, 3 Oct 2025 08:42:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F06021D131; Fri, 3 Oct 2025 08:42:32 +0200 (CEST) Date: Fri, 03 Oct 2025 08:42:25 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: In-Reply-To: MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1759473060.6ll3polgmk.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759473724316 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [pve-dev] Storage assisted copy feature for Proxmox storage plugin X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On October 3, 2025 2:15 am, Andrei Perapiolkin via pve-devel wrote: > Hi, > > Can the honorable community help me find an elegant way for > volume_import to identify the source volume origin type and name? > > I'm investigating this to implement storage-assisted copy (i.e., > performing the volume copy entirely on the storage side). > > My initial assumption was that this could be achieved by defining custom > volume_export and volume_import functions. > However, may be there is a better way to do storage assisted copy. volume_export and volume_import are only used for a few specific cases (mainly offline migration of local disks, and offline remote migration of disks). for those you could define your own transport format that includes or just contains the relevant metadata to do a storage side copy - it would only be selected if the storage for the source and target volume both say they support that particular format. I assume your storage is shared, so you'd be more interested in the move disk/full clone case, which currently uses either a mirror block job (if the VM is running), qemu-img convert (if the VM is not running) or rsync (for container volumes). These mechanisms are all not extensible at the moment for storage plugins. Maybe you could describe for which tasks you would see a clear benefit for extending the interface to allow a storage plugin to provide a "copy volume A into volume B storage side" - for the live move disk it might be hard (without dirty bitmap trickery like we use for replication, but that might be an option?), for the offline moves it would probably be possible to somehow special case this and let plugins opt in, we've discussed this ourselves in the past.. > P.S. > Just found out about > https://pve.proxmox.com/wiki/Storage_Plugin_Development:_Writing_a_Storage= > _Plugin_for_SSHFS > This is grate! > Many thanks for posting this article! Great that it found its intended audience! :) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel