From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B38841FF16F for ; Tue, 30 Sep 2025 19:37:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 377F8D8BF; Tue, 30 Sep 2025 19:38:01 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Dominik Csapak Date: Tue, 30 Sep 2025 19:36:10 +0200 Message-ID: <175925376551.516906.13322499800692827428.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250912093919.1715010-1-d.csapak@proxmox.com> References: <20250912093919.1715010-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759253856209 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH common] JSONSchema: property strings: handle boolean default_key consistently X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri, 12 Sep 2025 11:39:09 +0200, Dominik Csapak wrote: > A schema with a default_key that is of type boolean, e.g. > > ``` > enabled => { > type => 'boolean', > default_key = 1, > }, > ``` > (can be found for example in qemu-server's 'agent' property) > > [...] Applied, with the commit message reworked as I found it a bit hard to follow the examples that way, thanks! I also added some basic test system in a follow-up commit, for now it really focuses on this issue here, but should be relatively easy to expand to cover more code area of property string but also rest of JSON schema. [1/1] JSONSchema: property strings: handle boolean default_key consistently commit: ac547b8739dc8e40bc05b14e4431298104a6e0e2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel