From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E68AC1FF165 for ; Thu, 25 Sep 2025 16:24:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3AAD122C3A; Thu, 25 Sep 2025 16:24:31 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Fiona Ebner Date: Thu, 25 Sep 2025 16:13:27 +0200 Message-ID: <175880960204.2603558.12118019101823445414.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250925122829.70121-1-f.ebner@proxmox.com> References: <20250925122829.70121-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758810253679 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH-SERIES v2 qemu-server 0/2] fix #6207: vm status fixes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Thu, 25 Sep 2025 14:25:07 +0200, Fiona Ebner wrote: > Changes in v2 (many thanks to Thomas for the discussion!): > * New approach, return undef instead of caching previous value. > * Add new patch to improve how 'query-proxmox-support' QMP commands > are issued. > > If disk read/write cannot be queried because of QMP timeout, they > should not be reported as 0, because a consumer of the RRD stats > cannot distinguish between 0 being an actual 0 value and 0 being an > indicator for the absence of the real value. The RRD graphs in the UI > will already show this correctly. > > [...] Applied, thanks! btw., while technically correct to have only patch 1/2 marked as v2 as patch 2/2, I'd rather see the versioning per series not per patch, b4 e.g. also gets confused this way as it cannot find the v2 of patch 2/2. [1/2] fix #6207: vm status: return undef values when disk{read, write} cannot be queried commit: 528df523161aa424cc6dca69230eae1f9a503cef [2/2] vm status: also queue query-proxmox-support QMP commands commit: 31d6f5f63bd6edb6c43de3e0213d38199c350cd4 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel