From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DBAA91FF185 for ; Mon, 4 Aug 2025 16:07:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6AEBF32EA6; Mon, 4 Aug 2025 16:09:27 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Christoph Heiss Date: Mon, 4 Aug 2025 16:08:47 +0200 Message-ID: <175431652628.1516560.4613673992169983103.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250804133002.1625925-1-c.heiss@proxmox.com> References: <20250804133002.1625925-1-c.heiss@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754316546242 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] qm: cleanup: do dbus-vmstate safety cleanup silently when requested X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon, 04 Aug 2025 15:29:56 +0200, Christoph Heiss wrote: > First, moving to vm_stop_cleanup(), which is a better fit for this. > It gets called by the cleanup API method in case of unclean shutdown or > from inside the guest. > > In every case, the dbus-vmstate daemon should _never_ be running at this > point, as it is started only before migration and stopped directly after > migration, before vm_stop_cleanup() is even called. So it should only be > left running in case of a crash during migration. > > [...] Applied, tried to untangle the subject a bit, thanks! [1/1] vmstate: improve cleaning up dbus-vmstate and avoid spurious warning commit: 067a0f55bbf155936861d8844c91dfc16b883c1d _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel