From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 945471FF180 for ; Fri, 1 Aug 2025 14:55:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1FD8A196CC; Fri, 1 Aug 2025 14:57:14 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Lukas Wagner Date: Fri, 1 Aug 2025 14:52:24 +0200 Message-ID: <175405274372.2432529.8239150314582136063.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250801095431.117317-1-l.wagner@proxmox.com> References: <20250801095431.117317-1-l.wagner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754053016595 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.155 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH cluster 1/5] pmxcfs: status: add one more missing g_free X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri, 01 Aug 2025 11:54:27 +0200, Lukas Wagner wrote: > Otherwise we leak the memory that was already allocated for `filename`. > > Applied, thanks! But can you please add a cover-letter for any actual patch series (i.e., not just a single patch), as that provides some value even if it's empty, as it makes it very clear if trailers like T-b or R-b are intended for the full series or just a single patch out of it. b4 also uses the same logic to determine for which commits to apply the R-b and T-b too, so here I had to manually add Maximiliano's R-b and T-b to patch 2 to 5, as from b4's POV they where only supplied for patch 1/5. A diffstat over all patches is a side benefit, a short sentence as overview might be nice too, but for things like these here it can be even fine to not have that. Not a big thing, but would make my (and others using b4) life a bit easier and better ensure that tests and reviews get encoded into git, providing some recognition of that important work. [1/5] pmxcfs: status: add one more missing g_free commit: 8239d5c3657a0e3fe751689bce920b7c2c87e531 [2/5] pmxcfs: status: avoid unnecessary string allocations commit: 426cb07ed853db202aaa219b06be80e7bbb4c74c [3/5] pmxcfs: status: call g_strdup instead of g_strdup_printf when no formatting is needed commit: c66917260e8bdf2a76878baee0ba91c6f4469207 [4/5] pmxcfs: status: remove string literal params for g_strdup_printf commit: 0795244f98b6e5e34491b9a1b3967d5bf935afd8 [5/5] pmxcfs: status: avoid g_strdup when not needed commit: 054995ba3d43e2bfe1e8fcd3d63549e3579e6ef9 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel