From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9C0241FF165 for ; Thu, 31 Jul 2025 11:38:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85DD037179; Thu, 31 Jul 2025 11:40:13 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Fiona Ebner Date: Thu, 31 Jul 2025 11:39:54 +0200 Message-ID: <175395478424.702330.8479085983873056260.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250731090956.23443-1-f.ebner@proxmox.com> References: <20250731090956.23443-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753954798978 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH qemu-server] block job: mirror: always detach the target node upon cancelling X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Thu, 31 Jul 2025 11:09:49 +0200, Fiona Ebner wrote: > This is a further improvement after commit 8e671e79 ("block job: > mirror: always detach the target node upon error"). It might be > that a cancelled job ends up in concluded state without an error > being set in the result of the 'query-block-jobs' QMP command and > the target node would not be detached. To fix it, also detach the > target node when cancelling the job. This is correct even when the job > was cancelled after completion, as in that case, the drive is not > switched over to use the target node. > > [...] Applied, thanks! [1/1] block job: mirror: always detach the target node upon cancelling commit: 0b9090c6abf4a51558e9a6fba88388abe666a512 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel