From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A9DF51FF16B for ; Tue, 29 Jul 2025 17:53:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C4FA717C79; Tue, 29 Jul 2025 17:54:56 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Fiona Ebner Date: Tue, 29 Jul 2025 17:54:12 +0200 Message-Id: <175380419279.4123061.9989690869402162746.b4-ty@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250718125408.133376-4-f.ebner@proxmox.com> References: <20250718125408.133376-1-f.ebner@proxmox.com> <20250718125408.133376-4-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753804453330 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager 3/6] pve8to9: backup retention: increase severity of having 'maxfiles' setting configured X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri, 18 Jul 2025 14:51:14 +0200, Fiona Ebner wrote: > The 'maxfiles' setting is dropped with Proxmox VE 9, so make having > the setting configured a proper error rather than just a warning. > > Applied to stable-8 branch, thanks! This does not really hurt to have even if we do not follow through with the removal in PVE 9 in any case, especially as warning is already a pretty "scary" severity anyway, so I'd think that most user should have update their definitions already. FWIW, it could be nice to have a migration script though, mapping any left-over maxfiles entry to keep-last, but OTOH, it's basically a sed, so if more users surface that are unsure about what to do, we can provide them with a `sed` example, at least as stop-gap. [3/6] pve8to9: backup retention: increase severity of having 'maxfiles' setting configured commit: e44a90c25b0ada3d4ab49a7d5d71e8f6357a4240 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel