From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 318E01FF185 for ; Mon, 21 Jul 2025 17:37:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AC6091432F; Mon, 21 Jul 2025 17:38:46 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com, Christian Ebner Date: Mon, 21 Jul 2025 17:37:40 +0200 Message-ID: <175311225493.4182207.12311176489875401535.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250719125035.9926-4-c.ebner@proxmox.com> References: <20250719125035.9926-1-c.ebner@proxmox.com> <20250719125035.9926-4-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753112313515 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [pbs-devel] [PATCH proxmox v9 3/3] s3 client: wrap upload with retry into dedicated methods X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Sat, 19 Jul 2025 14:49:49 +0200, Christian Ebner wrote: > The `replace` boolean flag in the upload_with_retry() method > signature unfortunately is not very ergonomic and hinders code > readability. > > Therefore, wrap the method into helpers covering both variants, > encoding their behaviour in the method name instead. > > [...] Applied, thanks! [3/3] s3 client: wrap upload with retry into dedicated methods commit: 7bf21f9da58e74b77dfcd4c6ae00100d80768dad _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel