From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1226C1FF165 for ; Thu, 17 Jul 2025 21:29:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 912F8B727; Thu, 17 Jul 2025 21:30:01 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Stefan Hanreich Date: Thu, 17 Jul 2025 21:27:16 +0200 Message-ID: <175278043348.50117.15031806616811099604.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250717152841.397830-4-s.hanreich@proxmox.com> References: <20250717152841.397830-1-s.hanreich@proxmox.com> <20250717152841.397830-4-s.hanreich@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1752780566319 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied-series: [PATCH pve-manager 1/4] pve-sdn-commit: fix reloading logic X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Thu, 17 Jul 2025 17:28:38 +0200, Stefan Hanreich wrote: > The API for generating the SDN configuration has been changed in the > fabrics patch series ('387cc48'). Use the new API to commit the SDN > configuration on boot, since otherwise the one-shot service fails to > apply the SDN configuration on boot. > > The service was also missing an ifreload, since the ifupdown2 config > gets regenerated by SDN and needs to be applied before generating the > FRR configuration in order for the FRR config generation to work > properly. > > [...] Applied the four manager patches, thanks! It might be nice to early exit if there is no SDN configured, and maybe some other simple conditions we could check, as always reloading the interfaces even if not required seems not really ideal. But this can be followed up on. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel