From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A74E81FF165 for ; Thu, 17 Jul 2025 21:28:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3B7D4B667; Thu, 17 Jul 2025 21:29:31 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Friedrich Weber Date: Thu, 17 Jul 2025 21:27:14 +0200 Message-ID: <175278043348.50117.12048004201744201670.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250717165006.106126-1-f.weber@proxmox.com> References: <20250717165006.106126-1-f.weber@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1752780566219 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.182 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH common] tools: dump logfile: fix result type in case the file cannot be opened X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Thu, 17 Jul 2025 18:50:01 +0200, Friedrich Weber wrote: > The second return value of dump_logfile should be a reference to an > array of hash references (one per log line), but in case the file > cannot be opened, it currently directly returns a reference to a hash. > > As a result, the /nodes/{node}/tasks/{upid}/log endpoint response does > not match the schema in case the task log cannot be opened (for > example, does not exist). This was reported in enterprise support, as > it trips up external monitoring tools that query this endpoint. > > [...] Applied, thanks! [1/1] tools: dump logfile: fix result type in case the file cannot be opened (no commit info) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel