From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id F14B71FF16B for ; Tue, 15 Jul 2025 17:57:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 319C0A5D8; Tue, 15 Jul 2025 17:58:12 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Fiona Ebner Date: Tue, 15 Jul 2025 17:54:53 +0200 Message-ID: <175259489071.2125750.147329651536741991.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250605111109.52712-1-f.ebner@proxmox.com> References: <20250605111109.52712-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH v3 storage 1/2] fix #5071: zfs over iscsi: add 'zfs-base-path' configuration option X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Thu, 05 Jun 2025 13:11:08 +0200, Fiona Ebner wrote: > Use '/dev/zvol' as a base path for new storages for providers 'iet' > and 'LIO', because that is what modern distributions use. > > This is a breaking change regarding the addition of new storages on > older distributions, but it's enough to specify the base path '/dev' > explicitly for setups that require it. > > [...] Mario brought my attention to this series, so given that Christoph already tested it and it seems relatively straight-forward I rebased on perltidy'd master and applied, thanks! FWIW, I shortly pondered about potential implications for allowing users with Datastore.Allocate permission to pass an arbitrary absolute path here, but that's really no precedent for storage plugins (e.g., DirPlugin), so I do not think that warrants any special handling here. [1/2] fix #5071: zfs over iscsi: add 'zfs-base-path' configuration option commit: d181d0b1eea1ba77a3cbf970d0e076e916ea676f [2/2] zfs over iscsi: on-add hook: dynamically determine base path commit: 4fb733a9ac870348511e0d9da5bf90e3278a651a _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel