From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 658EE1FF16B
	for <inbox@lore.proxmox.com>; Tue, 15 Jul 2025 08:53:22 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id E09E4346D7;
	Tue, 15 Jul 2025 08:54:19 +0200 (CEST)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Christian Ebner <c.ebner@proxmox.com>
Date: Tue, 15 Jul 2025 08:53:44 +0200
Message-ID: <175256242179.1778852.7497941633757904389.b4-ty@proxmox.com>
X-Mailer: git-send-email 2.47.2
In-Reply-To: <20250711090035.241160-1-c.ebner@proxmox.com>
References: <20250711090035.241160-1-c.ebner@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.033 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_MSPIKE_H2       0.001 Average reputation (+2)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] applied: [pve-installer v2] run-env: filter out
 interfaces without valid mac address
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On Fri, 11 Jul 2025 11:00:35 +0200, Christian Ebner wrote:
> The installer assumes to have a valid mac address for all interfaces
> as provided by the runtime env json file. Deserialization will fail
> if this is not the case.
> 
> In some cases, the interface might however not provide a valid MAC
> address, for example the WWAN LTE module without any SIM installed on
> some laptops.
> 
> [...]

Agreeing with your assesment in the reply to v3, so applied this one, thanks!

[1/1] run-env: filter out interfaces without valid mac address
      commit: aff57231b3bf18d778deb9ff596aeb1b79048ecf


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel