From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4FA171FF17C for ; Wed, 9 Jul 2025 17:59:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8DD93105A1; Wed, 9 Jul 2025 17:59:56 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Friedrich Weber Date: Wed, 9 Jul 2025 17:57:08 +0200 Message-ID: <175207662533.1192376.2282676943004708424.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250709141034.169726-4-f.weber@proxmox.com> References: <20250709141034.169726-1-f.weber@proxmox.com> <20250709141034.169726-4-f.weber@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH pve-manager v5 1/1] pve8to9: check for LVM autoactivation and provide migration script X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Wed, 09 Jul 2025 16:10:00 +0200, Friedrich Weber wrote: > Starting with PVE 9, the LVM and LVM-thin plugins create new LVs with > the `--setautoactivation n` flag to fix #4997 [1]. However, this does > not affect already existing LVs of setups upgrading from PVE 8. > > Hence, add a new script under /usr/share/pve-manager/migrations that > finds guest volume LVs with autoactivation enabled on enabled and > active LVM and LVM-thin storages, and disables autoactivation for each > of them. Before doing so, ask the user for confirmation for each > storage. For non-interactive usecases, the user can pass an flag to > assume confirmation. Disabling autoactivation via lvchange updates the > LVM metadata, hence, the storage lock is acquired before proceeding. > To avoid holding the lock for too long and blocking other consumers, > the lvchange calls are batched and the lock is released between two > batches. Afterwards, check for remaining guest volume LVs with > autoactivation enabled (these may have been created while the lock was > not held). If there are still such LVs left, or if other errors > occurred, suggest the user to run the command again. > > [...] Applied, thanks! As quickly talked off-list: I pushed a follow-up commit to change the warning to a notice for the case where only local LVM storages are affected, as in that case a warning is IMO not justified, as keeping the status quo then has no known problems, and while it might be a bit cleaner and save a little bit of resources to not activate all local volumes on boot, it's not worth the relatively scary warning level. [1/1] pve8to9: check for LVM autoactivation and provide migration script commit: ebed71c822e25c03211cbf0f97a3ef0c25a3f86e _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel