* [pve-devel] applied: [pmg-devel] [PATCH proxmox] login: use 'PMG' as product for 'PMGQUAR' tickets
[not found] <20250625073844.609286-1-d.csapak@proxmox.com>
@ 2025-07-03 7:49 ` Thomas Lamprecht
0 siblings, 0 replies; only message in thread
From: Thomas Lamprecht @ 2025-07-03 7:49 UTC (permalink / raw)
To: pve-devel, pmg-devel, Dominik Csapak
On Wed, 25 Jun 2025 09:38:44 +0200, Dominik Csapak wrote:
> We derive the product name from the beginning of the ticket normally,
> but this does not work with PMGQUAR tickets. Since the cookie name uses
> the product name, this results in a `PMGQUARAuthCookie`, but the cookie
> still has to be `PMGAuthCookie` to work. To work around that, decouple
> the userid range of the ticket from the product range, and modify it so
> that PMGQUAR tickets return also PMG for the product. This will result
> in the correct `PMGAuthCookie` name.
>
> [...]
The shared cookie name is IMO not so great here in the first place, but works
OK-ish enough for all that are just spam quarantine users, and no PMG admins
or the like too. Maybe we can look into a clean seperation here for the future,
but nothing all to important for now.
Applied, thanks!
[1/1] login: use 'PMG' as product for 'PMGQUAR' tickets
commit: 33f9c3a41ad95d2c885568a78b389579665fc959
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-07-03 7:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250625073844.609286-1-d.csapak@proxmox.com>
2025-07-03 7:49 ` [pve-devel] applied: [pmg-devel] [PATCH proxmox] login: use 'PMG' as product for 'PMGQUAR' tickets Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox