From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 34F201FF170 for ; Thu, 26 Jun 2025 15:09:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 89E68395C8; Thu, 26 Jun 2025 15:10:00 +0200 (CEST) Date: Thu, 26 Jun 2025 15:09:52 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20250625155751.268047-1-f.ebner@proxmox.com> In-Reply-To: <20250625155751.268047-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1750942819.3m6x18vmut.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [drive.pm, qemuserver.pm, blockjob.pm] Subject: [pve-devel] partially-applied: [PATCH-SERIES qemu-server 00/31] preparation for blockdev, part three X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On June 25, 2025 5:56 pm, Fiona Ebner wrote: > Changes to OVMF patches (left-over from part two): > * 01/31 is new > * keep get_efivars_size() as a wrapper in QemuServer module > * keep early check for CPU bitness in QemuServer module > * use read-only flag for OVMF code > * collect some parameters into $hw_info hash, avoid querying AMD-SEV > type inside the OVMF module > > Splits out a Network module, qga_check_running(), > find_vmstate_storage(), QemuMigrate::Helpers, a RunState module with > the goal of splitting out a BlockJob module, where blockdev_mirror() > will be added. > > Need some more time to make zeroinit work properly, got an initial > QEMU patch locally, but need to finalize it. Also need to check why > exactly block-export-add fails without Alexandre's patch, since we do > query the node name there. We shouldn't use the top node there in any > case, because we don't want to be limited by limits intended for the > guest during migration. > > Therefore, the patches from 24/31 onwards are RFC, not finalized, just > for context and easier testing for reviewers. applied the non-RFC part (didn't do in-depth testing, but the changes are sensible) some follow-ups that would be nice to have, as discussed off-list: - get rid of the small (pre-existing!) back-reference from Drive.pm to QemuConfig.pm, by making the is_template bool a part of hw_info for OVMF purposes, and the helper in Drive.pm just return whether setting to read-only is possible. - reduce the public interface of BlockJob.pm to just `mirror`, `monitor` and `cancel` - make the names of subs in BlockJob shorter, the context is already there via the fully qualified name for external callers, and by virtue of being in the module for private subs - adapt the interface of qemu_drive_mirror to match the blockdev/public ones (i.e., use source and dest info and options) very nice work, we are now at 15% line count reduction for QemuServer.pm already! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel