From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 4C0DD1FF165
for <inbox@lore.proxmox.com>; Thu, 24 Apr 2025 19:38:52 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 4B6D6BAD3;
Thu, 24 Apr 2025 19:38:58 +0200 (CEST)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
Daniel Kral <d.kral@proxmox.com>
Date: Thu, 24 Apr 2025 19:33:35 +0200
Message-Id: <174551596005.4030446.11729269108713478737.b4-ty@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250411150634.253684-1-d.kral@proxmox.com>
References: <20250411150634.253684-1-d.kral@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.036 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [listvms.py, proxmox.com]
Subject: [pve-devel] applied: [PATCH esxi-import-tools 1/2] listvms: add
check for vCLS test whether vm configuration is present
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On Fri, 11 Apr 2025 17:06:33 +0200, Daniel Kral wrote:
> It seems that on older ESXi installations, e.g. ESXi 6.7 [0], there are
> virtual machines, which do not expose a config property for some VMs.
> Therefore, test whether the config is available before checking if the
> current entry is a vCLS VM.
>
> [0] https://forum.proxmox.com/threads/164900/
>
> [...]
Applied, but I had to make a followup for the second patch, which had a
logical error that was even reported on package build:
---
mypy listvms.py
listvms.py:261: error: "None" has no attribute "extraConfig" [attr-defined]
---
Would be great if you could end to end test changes.
As reference, I took this patch over the one from Daniel Herzig [0]
mostly due timing and the R-b trailer here.
[0]: https://lore.proxmox.com/all/20250423130315.360403-1-d.herzig@proxmox.com/
[1/2] listvms: add check for vCLS test whether vm configuration is present
commit: 3d3c4d60849a706fd3c9ad1402233fb4be09a38f
[2/2] listvms: add message when skipping vCLS agent VMs
commit: 9fee27b19e4cbd7f68adb0056d2fe8545a309700
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel