From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D25E868E29 for ; Fri, 23 Jul 2021 11:06:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C90871A527 for ; Fri, 23 Jul 2021 11:06:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5A8E91A519 for ; Fri, 23 Jul 2021 11:06:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1F580425CF for ; Fri, 23 Jul 2021 11:06:22 +0200 (CEST) Message-ID: <17451e51-c068-806a-505e-ebcf63609eab@proxmox.com> Date: Fri, 23 Jul 2021 11:05:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-US To: Proxmox VE development discussion , Stefan Reiter References: <20210705091412.155198-1-s.reiter@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210705091412.155198-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.404 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemu.pm] Subject: [pve-devel] applied: [PATCH qemu-server] api: always add new CD drives to bootorder X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jul 2021 09:06:22 -0000 On 05.07.21 11:14, Stefan Reiter wrote: > Attaching an ISO image to a VM is usually/often done for two reasons: > * booting an installer image > * supplying additional drivers to an installer (e.g. virtio) > > Both of these cases (the latter at least with SeaBIOS and the Windows > installer) require the disk to be marked as bootable. > > For this reason, enable the bootable flag for all new CDROM drives > attached to a VM by adding it to the bootorder list. It is appended to > the end, as otherwise it would cause new drives to boot before already > existing boot targets, which would be a more grave (and IMO bad) > behaviour change. > > Signed-off-by: Stefan Reiter > --- > PVE/API2/Qemu.pm | 8 ++++++++ > 1 file changed, 8 insertions(+) > > applied, thanks!