From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 41F621FF15E for <inbox@lore.proxmox.com>; Tue, 8 Apr 2025 16:51:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A73F730B80; Tue, 8 Apr 2025 16:51:41 +0200 (CEST) From: Thomas Lamprecht <t.lamprecht@proxmox.com> To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com> Date: Tue, 8 Apr 2025 16:51:03 +0200 Message-Id: <174412374768.4151951.11588292309931118803.b4-ty@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250408142014.86344-1-f.ebner@proxmox.com> References: <20250408142014.86344-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.036 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH-SERIES http-server 0/3] fix disconnecting clients X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On Tue, 08 Apr 2025 16:20:11 +0200, Fiona Ebner wrote: > Commit 07e56cc ("fix unexpected EOF for client when closing TLS > session") added a call to stoptls() before the call to shutdown() for > the handle's file descriptor. However, the documentation for > AnyEvent[0] mentions for stoptls(): > > > This method may invoke callbacks (and therefore the handle might be > > destroyed after it returns). > > [...] Applied, thanks! Btw. I did some benchmarks yesterday running `oha` [0] and I rechecked the logs and I found a handful of such error messages too that I did overlook before. With your patches I could not see them anymore after running a 10s five times (vs just once yesterday) [1/3] anyevent: disconnect: check that handle is still defined before calling shutdown() commit: 0ec627cff14a51695e6f81f86b34b398b07cf329 [2/3] anyevent: always avoid re-entering client_do_disconnect() in on_error callback commit: fa639169214f679c90274e4a6f1a84b864212326 [3/3] anyevent: handle 'disconnected' flag in client_do_disconnect() itself commit: f82b416214c94720c04dd02d5f5778af3439187f [0]: https://github.com/hatoo/oha _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel