From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 8A61A1FF162
for <inbox@lore.proxmox.com>; Mon, 7 Apr 2025 18:32:09 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id C36884A6E;
Mon, 7 Apr 2025 18:32:07 +0200 (CEST)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
Christoph Heiss <c.heiss@proxmox.com>
Date: Mon, 7 Apr 2025 18:31:59 +0200
Message-Id: <174404350519.2976133.9929553225850884419.b4-ty@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250407154810.1565150-1-c.heiss@proxmox.com>
References: <20250407154810.1565150-1-c.heiss@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.036 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] applied: [PATCH installer] common: options: use more
sensible fallback values for network options
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On Mon, 07 Apr 2025 17:47:47 +0200, Christoph Heiss wrote:
> When no DHCP server is configured on the network and/or no DHCP lease
> is received, the auto-installer falls back to Ipv4Addr::UNSPECIFIED -
> which resolves to `0.0.0.0/0` - for the interface address, gateway and
> DNS server. This is then written to /etc/network/interfaces and could
> cause further issues after the installation.
>
> At the same time, this also means that no interface name will be set,
> which causes the low-level installer to write out an invalid
> /etc/network/interfaces entry.
>
> [...]
Applied, thanks!
[1/1] common: options: use more sensible fallback values for network options
commit: ec5096be3dd974ffd79c7368a44a3ffbd2feb8a0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel