From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id B18A71FF162
for <inbox@lore.proxmox.com>; Mon, 7 Apr 2025 17:50:05 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 4C92E3B21;
Mon, 7 Apr 2025 17:50:03 +0200 (CEST)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
Stefan Hanreich <s.hanreich@proxmox.com>
Date: Mon, 7 Apr 2025 17:49:55 +0200
Message-Id: <174404096640.2941344.11228195579527806476.b4-ty@proxmox.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250310085103.30549-1-s.hanreich@proxmox.com>
References: <20250310085103.30549-1-s.hanreich@proxmox.com>
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.162 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] applied: [PATCH pve-network v2 1/8] ipam: netbox:
factor out common api methods and unify error handling
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On Mon, 10 Mar 2025 09:50:56 +0100, Stefan Hanreich wrote:
> Create a helper method that abstracts the common code used in making
> netbox requests. Move all api_request incovations over to using the
> helper method. This saves us from writing lots of repeated code.
>
> This also updates the helpers and introduces error checking there.
> Helpers didn't catch any errors and the invoking methods didn't as
> well. This meant that functions with $noerr set to 1 would still error
> out. We now pass $noerr to the helper functions and they behave the
> same as the parent methods. This requires some additional checks in
> the call sites of the helpers.
>
> [...]
Applied, thanks!
[1/8] ipam: netbox: factor out common api methods and unify error handling
commit: f5a439d194109da893d0376c2833e9dd23f2de46
[2/8] ipam: netbox: implement deleting subnets
commit: 449e08a8fb15d2ba21936250af0c228abec8d22c
[3/8] ipam: netbox: simplify helpers
commit: cea37c09da99adcaef1d7cf7dbbd8aa82796030d
[4/8] ipam: netbox: no conditional assignments for descriptions
commit: 5ff8aeb080ae99230fc6d2825722f49fd0fca3c0
[5/8] ipam: netbox: add error handling to get_ips_from_mac
commit: b673a106c5b25a5d9e2586c51be764bfb01df506
[6/8] partial fix #5496: ipam: netbox: properly return allocated ip
commit: f36174e0722d82ea5473c17c3d901e30899fcb7b
[7/8] partial fix #5496: ipam: netbox: create / delete ip ranges for dhcp
commit: a52a40c78b82e0646c60a28fc9919336a2cb1290
[8/8] partial fix #5496: subnet: ipam: add update_subnet hook
commit: 1b01ad6529516790cc19b22c2c389e1c41530738
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel