From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 926D91FF18E for <inbox@lore.proxmox.com>; Sun, 6 Apr 2025 21:59:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D0420310A1; Sun, 6 Apr 2025 21:59:53 +0200 (CEST) From: Thomas Lamprecht <t.lamprecht@proxmox.com> To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com> Date: Sun, 6 Apr 2025 21:59:12 +0200 Message-Id: <174396953020.1900884.15790130159681678128.b4-ty@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250303092445.13873-1-f.ebner@proxmox.com> References: <20250303092445.13873-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.412 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URI_NOVOWEL 0.5 URI hostname has long non-vowel sequence Subject: [pve-devel] applied: [PATCH-SERIES v2 storage 0/5] unsized subvol regression fix and improvements X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On Mon, 03 Mar 2025 10:24:40 +0100, Fiona Ebner wrote: > Changes in v2: > * comment out dead code in BTRFS plugin > * improve commit messages regarding clone > * squash patches 5/6 and 6/6 from v1 > > In list context, the file_size_info() function in Plugin.pm and the > volume_size_info() function in BTRFSPlugin.pm would return 0 for the > size, but in scalar context 1. As reported in the community forum [0], > the change in commit e50dde0 ("volume export: rely on storage plugin's > format"), changing the caller in volume_export() to scalar context > exposed the inconsistency in the return value for the size. This led > to breakage of migration with unsized btrfs subvolumes. > > [...] Applied, thanks! [1/5] plugin: file size info: be consistent about size of directory subvol commit: 544dc0e893549c62665991b58675fb71f4fe5aac [2/5] btrfs: fix volume size info for subvolumes in scalar context commit: 00105c8003aca8ba6499a4fbdd3803529e4671de [3/5] plugin: volume export formats: avoid superfluous file_size_info() call commit: d97d7ff676dae13ff6dc796103bbc2ef7f32f9e7 [4/5] api: volume info: do not fail for zero-sized subvolumes commit: 0426aa316598f329eacaf80e24638294e746c1be [5/5] btrfs: die early for broken subvolume resize commit: 5a73bac3439261da4b39c6ad22bd32d0ff19b2e6 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel