From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 02EC71FF17C for <inbox@lore.proxmox.com>; Wed, 2 Apr 2025 15:18:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 83C431B51B; Wed, 2 Apr 2025 15:18:35 +0200 (CEST) Date: Wed, 02 Apr 2025 15:17:58 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20250304115803.194820-1-m.frank@proxmox.com> In-Reply-To: <20250304115803.194820-1-m.frank@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1743599665.f3zigcahb8.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mapping.pm, qemu.pm, shared.pm, cluster.pm, memory.pm, dir.pm, qemuserver.pm, virtiofs.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v14 0/12] virtiofs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> other than the comments on individual patches nothing here jumped out at me for the backend part, I haven't looked at the front-end. some things that would be nice to consider/follow-up with: - add a hotplug feature (set up all the machinery, even if no virtiofs is configured yet, then add/remove shares at runtime?) - this would maybe allow removing shares before live-migrating/savevm-ing - keep an eye on upstream live-migration support for shared backing dirs - implement pve-container support via bind mounts On March 4, 2025 12:57 pm, Markus Frank wrote: > Virtio-fs is a shared file system that enables sharing a directory > between host and guest VMs. It takes advantage of the locality of > virtual machines and the hypervisor to get a higher throughput than > the 9p remote file system protocol. > > build-order: > 1. cluster > 2. guest-common > 3. docs > 4. qemu-server > 5. manager > > I did not get virtiofsd to run with run_command without creating > zombie processes after stutdown. So I replaced run_command with exec > for now. Maybe someone can find out why this happens. > > > changes in v14: > * disallow commas and equal signs in path until the path can be quoted > in property strings > * addressed style nits and improved formatting > * use max_virtiofs() in check_vm_create_dir_perm > * removed unnecessary checks after parse_property_string > * find_on_current_node returns only one entry > * improved docs > * added missing imports/uses > > changes in v13: > * removed acl/xattr attributes in node config > * renamed acl/xattr in virtiofs qemu config to expose-acl/expose-xattr > * renamed submounts in node config to announce-submounts > * the "disable snapshot (with RAM) and hibernate with virtio-fs devices" > patch now uses the check_non_migratable_resources function > * rewritten the part about announce-submounts in pve-docs patch > > Changes in v12: > * rebase to master as most patches could not be applied anymore > > Changes in v11: > * made submounts option on by default in WebUI and section config > * PVE::QemuServer::Virtiofs dependency removed in QemuServer/Memory.pm > * Minor changes to function/variable names > * Disable snapshots (with RAM) and hibernate due to incompatibility > > > > cluster: > > Markus Frank (1): > add mapping/dir.cfg for resource mapping > > src/PVE/Cluster.pm | 1 + > src/pmxcfs/status.c | 1 + > 2 files changed, 2 insertions(+) > > > > guest-common: > > Markus Frank (1): > add dir mapping section config > > src/Makefile | 1 + > src/PVE/Mapping/Dir.pm | 196 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 197 insertions(+) > create mode 100644 src/PVE/Mapping/Dir.pm > > > > docs: > > Markus Frank (1): > add doc section for the shared filesystem virtio-fs > > qm.adoc | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 97 insertions(+), 2 deletions(-) > > > > qemu-server: > > Markus Frank (4): > control: add virtiofsd as runtime dependency for qemu-server > fix #1027: virtio-fs support > migration: check_local_resources for virtiofs > disable snapshot (with RAM) and hibernate with virtio-fs devices > > PVE/API2/Qemu.pm | 41 ++++++- > PVE/QemuServer.pm | 46 +++++++- > PVE/QemuServer/Makefile | 3 +- > PVE/QemuServer/Memory.pm | 22 ++-- > PVE/QemuServer/Virtiofs.pm | 211 +++++++++++++++++++++++++++++++++++ > debian/control | 1 + > test/MigrationTest/Shared.pm | 7 ++ > 7 files changed, 317 insertions(+), 14 deletions(-) > create mode 100644 PVE/QemuServer/Virtiofs.pm > > > > manager: > > Markus Frank (5): > api: add resource map api endpoints for directories > ui: add edit window for dir mappings > ui: add resource mapping view for directories > ui: form: add selector for directory mappings > ui: add options to add virtio-fs to qemu config > > PVE/API2/Cluster/Mapping.pm | 7 + > PVE/API2/Cluster/Mapping/Dir.pm | 308 ++++++++++++++++++++++++++++ > PVE/API2/Cluster/Mapping/Makefile | 1 + > www/manager6/Makefile | 4 + > www/manager6/Utils.js | 1 + > www/manager6/dc/Config.js | 10 + > www/manager6/dc/DirMapView.js | 42 ++++ > www/manager6/form/DirMapSelector.js | 63 ++++++ > www/manager6/qemu/HardwareView.js | 19 ++ > www/manager6/qemu/VirtiofsEdit.js | 137 +++++++++++++ > www/manager6/window/DirMapEdit.js | 214 +++++++++++++++++++ > 11 files changed, 806 insertions(+) > create mode 100644 PVE/API2/Cluster/Mapping/Dir.pm > create mode 100644 www/manager6/dc/DirMapView.js > create mode 100644 www/manager6/form/DirMapSelector.js > create mode 100644 www/manager6/qemu/VirtiofsEdit.js > create mode 100644 www/manager6/window/DirMapEdit.js > > -- > 2.39.5 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel