From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 381021FF168
for <inbox@lore.proxmox.com>; Tue, 18 Mar 2025 11:49:40 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id D9D881C9DA;
Tue, 18 Mar 2025 11:49:26 +0100 (CET)
Date: Tue, 18 Mar 2025 11:48:49 +0100
From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20241206101007.156910-1-l.wagner@proxmox.com>
<20241206101007.156910-2-l.wagner@proxmox.com>
In-Reply-To: <20241206101007.156910-2-l.wagner@proxmox.com>
MIME-Version: 1.0
User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid)
Message-Id: <1742294885.ewnrqve9l2.astroid@yuna.none>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.044 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH proxmox-mail-forward 2/2] switch to
proxmox-log
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
based on the rest of the discussion, this will be rebased on top of the
builder from
https://lore.proxmox.com/pve-devel/20250218161311.558674-2-g.goller@proxmox.com/
?
On December 6, 2024 11:10 am, Lukas Wagner wrote:
> The proxmox-notify crate now uses tracing for logging,
> hence we have to switch to proxmox-log (which configures the appropriate
> layers/subscribers for tracing).
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> Cargo.toml | 5 ++---
> src/main.rs | 16 +++++++---------
> 2 files changed, 9 insertions(+), 12 deletions(-)
>
> diff --git a/Cargo.toml b/Cargo.toml
> index 0f4e3b0..9dc081b 100644
> --- a/Cargo.toml
> +++ b/Cargo.toml
> @@ -15,9 +15,8 @@ exclude = [ "debian" ]
>
> [dependencies]
> anyhow = "1.0"
> -log = "0.4.17"
> nix = "0.26"
> -syslog = "6.0"
>
> -proxmox-sys = "0.6"
> +proxmox-log = "0.2"
> proxmox-notify = {version = "0.5", features = ["mail-forwarder", "pve-context", "pbs-context"] }
> +proxmox-sys = "0.6"
> diff --git a/src/main.rs b/src/main.rs
> index 4662ffa..c0ea561 100644
> --- a/src/main.rs
> +++ b/src/main.rs
> @@ -23,6 +23,8 @@ use std::path::Path;
>
> use anyhow::Error;
>
> +use proxmox_log::error;
> +use proxmox_log::LevelFilter;
> use proxmox_notify::context::pbs::PBS_CONTEXT;
> use proxmox_notify::context::pve::PVE_CONTEXT;
> use proxmox_notify::Config;
> @@ -42,7 +44,7 @@ fn attempt_file_read<P: AsRef<Path>>(path: P) -> Option<String> {
> match fs::file_read_optional_string(path.as_ref()) {
> Ok(contents) => contents,
> Err(err) => {
> - log::error!("unable to read {path:?}: {err}", path = path.as_ref());
> + error!("unable to read {path:?}: {err}", path = path.as_ref());
> None
> }
> }
> @@ -112,11 +114,7 @@ fn forward_for_pbs(mail: &[u8], has_pve: bool) -> Result<(), Error> {
> }
>
> fn main() {
> - if let Err(err) = syslog::init(
> - syslog::Facility::LOG_DAEMON,
> - log::LevelFilter::Info,
> - Some("proxmox-mail-forward"),
> - ) {
> + if let Err(err) = proxmox_log::init_logger("PROXMOX_LOG", LevelFilter::INFO) {
> eprintln!("unable to initialize syslog: {err}");
> }
>
> @@ -129,19 +127,19 @@ fn main() {
> if Path::new(PVE_CFG_PATH).exists() {
> has_pve = true;
> if let Err(err) = forward_for_pve(&mail) {
> - log::error!("could not forward mail for Proxmox VE: {err}");
> + error!("could not forward mail for Proxmox VE: {err}");
> }
> }
>
> // Assume a PBS installation if /etc/proxmox-backup exists
> if Path::new(PBS_CFG_PATH).exists() {
> if let Err(err) = forward_for_pbs(&mail, has_pve) {
> - log::error!("could not forward mail for Proxmox Backup Server: {err}");
> + error!("could not forward mail for Proxmox Backup Server: {err}");
> }
> }
> }
> Err(err) => {
> - log::error!("could not read mail from STDIN: {err}")
> + error!("could not read mail from STDIN: {err}")
> }
> }
> }
> --
> 2.39.5
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel