From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id F0DEB1FF163 for <inbox@lore.proxmox.com>; Thu, 19 Dec 2024 12:46:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1CADF3688; Thu, 19 Dec 2024 12:46:16 +0100 (CET) Date: Thu, 19 Dec 2024 12:45:38 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20241219104316.35329-1-f.ebner@proxmox.com> In-Reply-To: <20241219104316.35329-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1734608618.yj7heajgo8.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] partially-applied: [PATCH storage/container v3 00/13] import/export for shared storages X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Folded in Filip's T-B from v2, and applied all but the last pve-container patch - those checks are there to cancel the migration early on if a storage that is not supported is contained in the mix.. ideally they should move to the storage layer, as the original comment indicates.. basically a helper that checks export and import formats (and snapshots/base status) and returns a bool? On December 19, 2024 11:43 am, Fiona Ebner wrote: > Chnages in v3: > * add fix for path() calls in Plugin.pm > * use rbd export/import instead of mapping+dd > * list images for volume exists helper > * fix commit message for patch adding Common module > * add patch dropping outdated error message check > > Changes in v2: > * add fix for path() in iSCSI direct plugin > * add export for iSCSI plugins > * add RFC for improving RBD volume exists helper > > For remote migration, export/import functionality is also useful for > storages that are shared within a single cluster. While file-based > network storages already can rely on the default file-based > implementation in Plugin.pm, RBD and iSCSI plugins did not have the > functionality yet. > > > Regarding RBD: > > For now, only 'raw+size' is supported and it's not possible to > export/import with snapshots. The volume or snapshot is mapped using > rbd and then the data is read via 'dd'. > > Introducing an 'rbd' transport format might be feasible for more > complete (i.e. with snapshots, incremental) transfer between two RBD > storages. > > > For iSCSI plugins, remote migration will still fail further up the > stack though: > >> can't migrate local disk 'iscsidirect:lun0': owned by other VM (owner = VM ) >> can't migrate local disk 'iscsi:0.0.0.scsi-360014055b29367fb79a46b0bdb179fae': owned by other VM (owner = VM ) > > pve-storage: > > Fiona Ebner (10): > plugin: export/import: fix calls to path() method > rbd plugin: schema: document default value for 'krbd' setting > export: redirect stdout to avoid any unrelated messages ending up in > the export stream > rbd plugin: factor out helper to check if volume already exists > rbd plugin: implement volume import/export > rbd plugin: improve volume exists helper > iscsi plugin: support volume export > iscsi direct plugin: support volume export > plugins: volume import: align size up to 1KiB > rbd plugin: list: drop outdated error message check > > Max Carrara (1): > common: introduce common module > > src/PVE/CLI/pvesm.pm | 5 +- > src/PVE/Storage/Common.pm | 54 ++++++++++ > src/PVE/Storage/Common/Makefile | 6 ++ > src/PVE/Storage/ISCSIDirectPlugin.pm | 63 ++++++++++++ > src/PVE/Storage/ISCSIPlugin.pm | 48 +++++++++ > src/PVE/Storage/LVMPlugin.pm | 4 +- > src/PVE/Storage/Makefile | 2 + > src/PVE/Storage/Plugin.pm | 12 ++- > src/PVE/Storage/RBDPlugin.pm | 142 ++++++++++++++++++++++++--- > 9 files changed, 317 insertions(+), 19 deletions(-) > create mode 100644 src/PVE/Storage/Common.pm > create mode 100644 src/PVE/Storage/Common/Makefile > > > pve-container: > > Fiona Ebner (2): > migration: allow rbd storages for remote migration > migration: add reminder to evaluate dropping seemingly useless check > for PVE 9 > > src/PVE/LXC/Migrate.pm | 3 +++ > 1 file changed, 3 insertions(+) > > > Summary over all repositories: > 10 files changed, 320 insertions(+), 19 deletions(-) > > -- > Generated by git-murpp 0.5.0 > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel