From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E528D1FF15C for ; Wed, 13 Nov 2024 14:18:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 36BAB15AA9; Wed, 13 Nov 2024 14:18:57 +0100 (CET) Date: Wed, 13 Nov 2024 14:18:51 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20241104183225.1192830-1-me@bennetgallein.de> <20241104183225.1192830-3-me@bennetgallein.de> In-Reply-To: <20241104183225.1192830-3-me@bennetgallein.de> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1731503012.c1v1nlc32y.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH cluster/qemu-server/container 1/1] add purge_rrd_data sub X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On November 4, 2024 7:32 pm, Bennet Gallein wrote: > Signed-off-by: Bennet Gallein > --- > src/PVE/RRD.pm | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/src/PVE/RRD.pm b/src/PVE/RRD.pm > index 5d4abc9..636226c 100644 > --- a/src/PVE/RRD.pm > +++ b/src/PVE/RRD.pm > @@ -6,6 +6,26 @@ use RRDs; > > use PVE::Tools; > > +sub purge_rrd_data { > + my ($rrdname) = @_; > + > + my $rrddir = "/var/lib/rrdcached/db"; > + > + my $rrd = "$rrddir/$rrdname"; > + > + my @args = (); > + my $socket = "/var/run/rrdcached.sock"; > + push @args, "--daemon" => "unix:$socket" if -S $socket; > + > + # flush cached RRDs > + RRDs::flushcached($rrd, @args); isn't this racy - if another RRD update happens between this > + > + my $err = RRDs::error; > + die "RRD error flushing pre-purge: $err\n" if $err; > + > + unlink($rrd) or die("ERROR deleting RRD file"); and this? I think this would need to be broadcasted as well (and handled in pmxcfs? that would also allow discarding broadcasts with earlier timestamps), else RRD data on other nodes in a cluster is still around (see PVE/Service/pvestatd.pm in pve-manager , and src/pmxcfs/status.c here in pve-cluster).. > +} > + > sub create_rrd_data { > my ($rrdname, $timeframe, $cf) = @_; > > -- > 2.39.5 > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel