From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CFB2F1FF15C for ; Wed, 13 Nov 2024 13:56:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B2A615369; Wed, 13 Nov 2024 13:56:00 +0100 (CET) Date: Wed, 13 Nov 2024 13:55:53 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240830223430.237913-1-thomas@atskinner.net> In-Reply-To: <20240830223430.237913-1-thomas@atskinner.net> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1731502483.864ppgi51w.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH openid 0/1] Make OIDC userinfo endpoint optional X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Thomas Skinner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On August 31, 2024 12:34 am, Thomas Skinner wrote: > In the OpenID Connect documentation (https://openid.net/specs/openid-connect-core-1_0.html), the > protocol abstract defined in 1.3 states in step 4 that "The RP can send a request with the Access > Token to the UserInfo Endpoint", which would imply that getting information from the UserInfo > endpoint is not a requirement for the protocol. Some OpenID Providers (e.g. ADFS) do not support > retrieving any additional claims in the UserInfo endpoint. > > This patch changes the userinfo claims to be optional instead of required. If the claims can be > retrieved successfully from the userinfo endpoint, they are returned as retrieved. If the claims > cannot be retrieved successfully, the claims are returned as None. > > While this patch does not explicitly add an option as requested in bug #4234, it does fix issue of > the userinfo endpoint not providing claims properly. > > It would be nice to have some log output when claims cannot be retrieved for troubleshooting > purposes, but I'm not sure how the PVE team would prefer that be handled. > > Thomas Skinner (1): > fix #4234: openid: make userinfo request optional > > proxmox-openid/src/lib.rs | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) a heads-up for this patch here (the group series only needs to consider this if the API changes, unless PBS gains group support in the meantime ;) - proxmox-openid is also used by PBS, not just by PVE, so there might be changed needed on that side as well depending on how the API is adapted.. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel