From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4821A1FF15C for ; Wed, 13 Nov 2024 13:47:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 924FD152C2; Wed, 13 Nov 2024 13:47:33 +0100 (CET) Date: Wed, 13 Nov 2024 13:47:27 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240901165512.687801-1-thomas@atskinner.net> <20240901165512.687801-4-thomas@atskinner.net> In-Reply-To: <20240901165512.687801-4-thomas@atskinner.net> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1731502015.ra8ytnc1y3.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH access-control 1/1] fix #4411: openid: add logic for openid groups support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Thomas Skinner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On September 1, 2024 6:55 pm, Thomas Skinner wrote: > Signed-off-by: Thomas Skinner > --- > src/PVE/API2/OpenId.pm | 32 ++++++++++++++++++++++++++++++++ > src/PVE/Auth/OpenId.pm | 21 +++++++++++++++++++++ > 2 files changed, 53 insertions(+) > > diff --git a/src/PVE/Auth/OpenId.pm b/src/PVE/Auth/OpenId.pm > index c8e4db9..0e3fdc4 100755 > --- a/src/PVE/Auth/OpenId.pm > +++ b/src/PVE/Auth/OpenId.pm > @@ -42,6 +42,24 @@ sub properties { > type => 'string', > optional => 1, > }, > + "groups-claim" => { > + description => "OpenID claim used to retrieve groups with.", > + type => 'string', forgot this part: this should probably have a format to limit valid values.. > + optional => 1, > + }, > + "groups-overwrite" => { > + description => "All groups will be overwritten for the user on login.", > + type => 'boolean', > + default => 0, > + optional => 1, > + }, > + "groups-replace-character" => { > + description => "Character used to replace any invalid characters in groups from provider.", > + type => 'string', > + pattern => '^[A-Za-z0-9\.\-_]$', > + default => '_', > + optional => 1, > + }, > prompt => { > description => "Specifies whether the Authorization Server prompts the End-User for" > ." reauthentication and consent.", > @@ -73,6 +91,9 @@ sub options { > "client-key" => { optional => 1 }, > autocreate => { optional => 1 }, > "username-claim" => { optional => 1, fixed => 1 }, > + "groups-claim" => { optional => 1 }, > + "groups-overwrite" => { optional => 1 }, > + "groups-replace-character" => { optional => 1}, > prompt => { optional => 1 }, > scopes => { optional => 1 }, > "acr-values" => { optional => 1 }, > -- > 2.39.2 > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel