From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C9BE81FF15C for ; Wed, 13 Nov 2024 12:36:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0A30214250; Wed, 13 Nov 2024 12:36:46 +0100 (CET) Date: Wed, 13 Nov 2024 12:36:39 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240910003026.667328-1-thomas@atskinner.net> <20240910003026.667328-2-thomas@atskinner.net> In-Reply-To: <20240910003026.667328-2-thomas@atskinner.net> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1731497711.bteksvwi6f.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH docs 1/1] fix #5699: pveproxy: add docs for real IP support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Thomas Skinner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" thanks for sending docs along with your feature patch! this one looks good to me, but see my comments on the feature patch itself. On September 10, 2024 2:30 am, Thomas Skinner wrote: > --- > pveproxy.adoc | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/pveproxy.adoc b/pveproxy.adoc > index 4b5dac0..f0ae0f7 100644 > --- a/pveproxy.adoc > +++ b/pveproxy.adoc > @@ -198,6 +198,35 @@ content, if the client supports it. This can disabled in `/etc/default/pveproxy` > > COMPRESSION=0 > > +[[pveproxy_real_ip]] > +Real Client IP Logging > +---------------------- > + > +By default, `pveproxy` logs the IP address of the client that sent the request. > +In cases where a proxy server is in front of `pveproxy`, it may be desirable to > +log the IP of the client making the request instead of the proxy IP. > + > +To enable processing of a HTTP header set by the proxy for logging purposes, set > +`PROXY_REAL_IP_HEADER` to the name of the header to retrieve the client IP from. For > +example: > + > + PROXY_REAL_IP_HEADER="X-Forwarded-For" > + > +Any invalid values passed in this header will be ignored. > + > +The default behavior is log the value in this header on all incoming requests. > +To define a list of proxy servers that should be trusted to set the above HTTP > +header, set `TRUSTED_PROXY_IPS`, for example: > + > + TRUSTED_PROXY_IPS="192.168.0.2" > + > +The `TRUSTED_PROXY_IPS` setting also supports values similar to the `ALLOW_FROM` > +and `DENY_FROM` settings. > + > +IP addresses can be specified using any syntax understood by `Net::IP`. The > +name `all` is an alias for `0/0` and `::/0` (meaning all IPv4 and IPv6 > +addresses). > + > ifdef::manvolnum[] > include::pve-copyright.adoc[] > endif::manvolnum[] > -- > 2.39.2 > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel