From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 20A671FF16B for ; Thu, 31 Oct 2024 13:35:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9C7679630; Thu, 31 Oct 2024 13:35:35 +0100 (CET) Date: Thu, 31 Oct 2024 13:34:58 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20241030134402.310205-1-m.sandoval@proxmox.com> In-Reply-To: <20241030134402.310205-1-m.sandoval@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1730376856.afm8la86wu.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager 1/2] api: nodes: index: specify the type of SSL certificate X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On October 30, 2024 2:44 pm, Maximiliano Sandoval wrote: > The function internally calls > PVE::Certificate::get_certificate_fingerprint which in turn calls: > > ``` > my $fp = Net::SSLeay::X509_get_fingerprint($cert, 'sha256'); > ``` > > Signed-off-by: Maximiliano Sandoval > --- > PVE/API2/Nodes.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm > index e8ff6dd9..1db148af 100644 > --- a/PVE/API2/Nodes.pm > +++ b/PVE/API2/Nodes.pm > @@ -2567,7 +2567,7 @@ __PACKAGE__->register_method ({ > renderer => 'duration', > }, > ssl_fingerprint => { > - description => "The SSL fingerprint for the node certificate.", > + description => "The SSL SHA-256 fingerprint for the node certificate.", what is an "SSL SHA-256 fingerprint"? the original was already bad, but this made it worse.. the standard option has "Certificate SHA 256 fingerprint" as description, IMHO that would already be quite okay here? after all, if there is only a single fingerprint returned per node, it's quite clear which certificate it belongs to? or if you want to make it more specific, then use something like "The SHA-256 fingerprint of the node's TLS certificate" > type => 'string', > optional => 1, > }, > -- > 2.39.5 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel