From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7BCC31FF172 for ; Tue, 3 Sep 2024 11:37:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6784B18E26; Tue, 3 Sep 2024 11:37:56 +0200 (CEST) Date: Tue, 03 Sep 2024 11:37:48 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240813084257.12720-1-f.ebner@proxmox.com> In-Reply-To: <20240813084257.12720-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1725356019.j6qd6dvcqg.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, qemumigrate.pm] Subject: Re: [pve-devel] [PATCH v2 qemu-server] remote migration: fix online migration via API clients X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On August 13, 2024 10:42 am, Fiona Ebner wrote: > As reported in the community forum [0], when a remote migration > request comes in via an API client, the -T flag for Perl is set, so an > insecure dependency in a call like unlink() in forward_unix_socket() > will fail with: > >> failed to write forwarding command - Insecure dependency in unlink while running with -T switch > > To fix it, untaint the problematic socket addresses coming from the > remote side. Require that all sockets are below '/run/qemu-server/' > and end with '.migrate'. This allows extensions in the future while > still being quite strict. > > [0]: https://forum.proxmox.com/threads/123048/post-691958 > > Signed-off-by: Fiona Ebner > --- > > Changes in v2: > * rule out '../' in path > > PVE/QemuMigrate.pm | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm > index e71face4..d31589e7 100644 > --- a/PVE/QemuMigrate.pm > +++ b/PVE/QemuMigrate.pm > @@ -1095,7 +1095,10 @@ sub phase2 { > die "only UNIX sockets are supported for remote migration\n" > if $tunnel_info->{proto} ne 'unix'; > > - my $remote_socket = $tunnel_info->{addr}; > + # untaint > + my ($remote_socket) = > + $tunnel_info->{addr} =~ m|^(/run/qemu-server/(?:(?!\.\./).)+\.migrate)$|; should we just switch to `\d+`, like we do for regular migration? in phase2_start_local_cluster we have: elsif ($line =~ m!^migration listens on (unix):(/run/qemu-server/(\d+)\.migrate)$!) { $tunnel_info->{addr} = $2; die "Destination UNIX sockets VMID does not match source VMID" if $vmid ne $3; $tunnel_info->{proto} = $1; } and I don't really see a reason to deviate from that scheme any time soon? > + die "unexpected socket address '$tunnel_info->{addr}'\n" if !$remote_socket; > my $local_socket = $remote_socket; > $local_socket =~ s/$remote_vmid/$vmid/g; > $tunnel_info->{addr} = $local_socket; > @@ -1104,6 +1107,9 @@ sub phase2 { > PVE::Tunnel::forward_unix_socket($self->{tunnel}, $local_socket, $remote_socket); > > foreach my $remote_socket (@{$tunnel_info->{unix_sockets}}) { > + # untaint > + ($remote_socket) = $remote_socket =~ m|^(/run/qemu-server/(?:(?!\.\./).)+\.migrate)$| > + or die "unexpected socket address '$remote_socket'\n"; > my $local_socket = $remote_socket; > $local_socket =~ s/$remote_vmid/$vmid/g; > next if $self->{tunnel}->{forwarded}->{$local_socket}; > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel