From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1D45B1FF2C7 for ; Wed, 24 Jul 2024 13:46:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6BDF81AF3A; Wed, 24 Jul 2024 13:47:04 +0200 (CEST) Date: Wed, 24 Jul 2024 13:46:27 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Fiona Ebner , Max Carrara , Proxmox VE development discussion References: <20240604092850.126083-1-m.carrara@proxmox.com> <54106e85-064f-42db-bc5e-0f7e43495de8@proxmox.com> In-Reply-To: <54106e85-064f-42db-bc5e-0f7e43495de8@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1721821515.pav2aht0gp.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, sectionconfig.pm] Subject: Re: [pve-devel] applied: [PATCH v1 pve-common 0/3] Section Config: Documentation & Code Cleanup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On July 24, 2024 1:34 pm, Fiona Ebner wrote: > Am 04.06.24 um 11:28 schrieb Max Carrara: >> >> Max Carrara (3): >> section config: document package and its methods with POD >> section config: update code style >> section config: clean up parser logic >> >> src/PVE/SectionConfig.pm | 982 +++++++++++++++++++++++++++++++-------- >> 1 file changed, 798 insertions(+), 184 deletions(-) >> > > For the record, it seems like this already got applied: > https://git.proxmox.com/?p=pve-common.git;a=commit;h=6cba8d7660b62002ffdc81655b8e8668952614a9 > > Could you re-send the changes for v2 as follow-ups? Or v1 could also be > reverted and v2 applied? I reverted them for now - it seems they accidentally slipped in when I applied an unrelated patch cause of a dirty repo state I missed before pushing.. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel