From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 44EC21FF2C6 for ; Wed, 10 Jul 2024 15:03:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4B4009A29; Wed, 10 Jul 2024 15:03:42 +0200 (CEST) Date: Wed, 10 Jul 2024 15:03:05 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240423082714.123525-1-m.sandoval@proxmox.com> In-Reply-To: <20240423082714.123525-1-m.sandoval@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1720616308.ksnjid827r.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH manager 1/4] ui: homogenize uses of Zstd and SCSI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On April 23, 2024 10:27 am, Maximiliano Sandoval wrote: > See [1, 2] for their spelling. > > [1] https://en.wikipedia.org/wiki/Zstd neither the upstream repo, nor the corresponding RFC indicate that this is the desired spelling (it is "Zstandard", but the short variant is called "zstd" in both places, except for a single "Zstd" in the Readme of the repo, which might as well be a typo ;)). you have to ignore all the occurences at the start of a sentence of course.. > [2] https://en.wikipedia.org/wiki/SCSI > > Signed-off-by: Maximiliano Sandoval > --- > www/manager6/form/BackupCompressionSelector.js | 2 +- > www/manager6/panel/BackupAdvancedOptions.js | 2 +- > www/manager6/window/DownloadUrlToStorage.js | 2 +- > www/manager6/window/GuestImport.js | 1 + > 4 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/www/manager6/form/BackupCompressionSelector.js b/www/manager6/form/BackupCompressionSelector.js > index 014b8f7e..2efc2919 100644 > --- a/www/manager6/form/BackupCompressionSelector.js > +++ b/www/manager6/form/BackupCompressionSelector.js > @@ -5,6 +5,6 @@ Ext.define('PVE.form.BackupCompressionSelector', { > ['0', Proxmox.Utils.noneText], > ['lzo', 'LZO (' + gettext('fast') + ')'], > ['gzip', 'GZIP (' + gettext('good') + ')'], funnily enough, GZIP would be the more likely candidate for such a change, after all it is normally just spelled `gzip`.. > - ['zstd', 'ZSTD (' + gettext('fast and good') + ')'], > + ['zstd', 'Zstd (' + gettext('fast and good') + ')'], > ], > }); > diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js > index c79c31cb..a9c8a05a 100644 > --- a/www/manager6/panel/BackupAdvancedOptions.js > +++ b/www/manager6/panel/BackupAdvancedOptions.js > @@ -136,7 +136,7 @@ Ext.define('PVE.panel.BackupAdvancedOptions', { > endFlex: 2, > endColumn: { > xtype: 'displayfield', > - value: `${gettext('Threads used for zstd compression (non-PBS).')} ${Ext.String.format(gettext("Schema default: {0}"), 1)}`, > + value: `${gettext('Threads used for Zstd compression (non-PBS).')} ${Ext.String.format(gettext("Schema default: {0}"), 1)}`, > }, > }, > { > diff --git a/www/manager6/window/DownloadUrlToStorage.js b/www/manager6/window/DownloadUrlToStorage.js > index 5523a152..f165e3a9 100644 > --- a/www/manager6/window/DownloadUrlToStorage.js > +++ b/www/manager6/window/DownloadUrlToStorage.js > @@ -227,7 +227,7 @@ Ext.define('PVE.window.DownloadUrlToStorage', { > ['__default__', Proxmox.Utils.NoneText], > ['lzo', 'LZO'], > ['gz', 'GZIP'], > - ['zst', 'ZSTD'], > + ['zst', 'Zstd'], > ], > cbind: { > hidden: get => get('content') !== 'iso', > diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js > index 944d275b..69e7c9bb 100644 > --- a/www/manager6/window/GuestImport.js > +++ b/www/manager6/window/GuestImport.js > @@ -924,6 +924,7 @@ Ext.define('PVE.window.GuestImport', { > 'cdrom-image-ignored': gettext("CD-ROM images cannot get imported, if required you can reconfigure the '{0}' drive in the 'Advanced' tab."), > 'nvme-unsupported': gettext("NVMe disks are currently not supported, '{0}' will get attaced as SCSI"), > 'ovmf-with-lsi-unsupported': gettext("OVMF is built without LSI drivers, scsi hardware was set to '{1}'"), > + 'ovmf-with-lsi-unsupported': gettext("OVMF is built without LSI drivers, SCSI hardware was set to '{1}'"), if the two corrections were separate patches, I could have already applied this one, alas.. > 'serial-port-socket-only': gettext("Serial socket '{0}' will be mapped to a socket"), > 'guest-is-running': gettext('Virtual guest seems to be running on source host. Import might fail or have inconsistent state!'), > 'efi-state-lost': Ext.String.format( > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel