From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 22CEB1FF348 for ; Wed, 17 Apr 2024 15:12:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5155975A8; Wed, 17 Apr 2024 15:12:20 +0200 (CEST) Date: Wed, 17 Apr 2024 15:11:37 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240416131909.2867605-1-d.csapak@proxmox.com> In-Reply-To: <20240416131909.2867605-1-d.csapak@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1713359271.xtvijc9iex.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage/qemu-server/pve-manager] implement ova/ovf import for directory type storages X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On April 16, 2024 3:18 pm, Dominik Csapak wrote: > This series enables importing ova/ovf from directory based storages, > inclusive upload/download via the webui (ova only). > > It also improves the ovf importer by parsing the ostype, nics, bootorder > (and firmware from vmware exported files). > > I currently opted to move the OVF.pm to pve-storage, since there is no > real other place where we could put it. Building a seperate package > from qemu-servers git repo would also not be ideal, since we still > have a cyclic dev dependency then > (If someone has a better idea how to handle that, please do tell, and > i can do that in a v2) > > There are surely some wrinkles left i did not think of, but all in all, > it should be pretty usable. E.g. i downloaded some ovas, uploaded them > on my cephfs in my virtual cluster, and successfully imported that with > live-import. > > The biggest caveat when importing from ovas is that we have to > temporarily extract the disk images. I opted for doing that into the > import storage, but if we have a better idea where to put that, i can > implement it in a v2 (or as a follow up). For example, we could add a > new 'tmpdir' parameter to the create call and use that for extractig. something is wrong with the permissions, since the import images are not added to check_volume_access, I can now upload an OVA, but not see it afterwards ;) I guess if a user has upload rights for improt images (Datastore.AllocateTemplate), they should also be able to see and use (and remove) import images? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel