From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 62CD31FF348 for ; Wed, 17 Apr 2024 14:37:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B16F26846; Wed, 17 Apr 2024 14:37:53 +0200 (CEST) Date: Wed, 17 Apr 2024 14:37:16 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240416131909.2867605-1-d.csapak@proxmox.com> <20240416131909.2867605-17-d.csapak@proxmox.com> In-Reply-To: <20240416131909.2867605-17-d.csapak@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1713357424.7mmqzxs85n.astroid@yuna.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH manager 4/4] ui: enable upload/download buttons for 'import' type storages X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On April 16, 2024 3:19 pm, Dominik Csapak wrote: > but only for non esxi ones, since that does not allow > uploading/downloading there what about a remove button? :) > > Signed-off-by: Dominik Csapak > --- > www/manager6/storage/Browser.js | 7 ++++++- > www/manager6/window/UploadToStorage.js | 1 + > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js > index 2123141d..77d106c1 100644 > --- a/www/manager6/storage/Browser.js > +++ b/www/manager6/storage/Browser.js > @@ -28,7 +28,9 @@ Ext.define('PVE.storage.Browser', { > let res = storageInfo.data; > let plugin = res.plugintype; > > - me.items = plugin !== 'esxi' ? [ > + let isEsxi = plugin === 'esxi'; > + > + me.items = !isEsxi ? [ > { > title: gettext('Summary'), > xtype: 'pveStorageSummary', > @@ -144,6 +146,9 @@ Ext.define('PVE.storage.Browser', { > content: 'import', > useCustomRemoveButton: true, // hide default remove button > showColumns: ['name', 'format'], > + enableUploadButton: enableUpload && !isEsxi, > + enableDownloadUrlButton: enableDownloadUrl && !isEsxi, > + useUploadButton: !isEsxi, > itemdblclick: (view, record) => createGuestImportWindow(record), > tbar: [ > { > diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js > index 3c5bba88..79a6e8a6 100644 > --- a/www/manager6/window/UploadToStorage.js > +++ b/www/manager6/window/UploadToStorage.js > @@ -11,6 +11,7 @@ Ext.define('PVE.window.UploadToStorage', { > acceptedExtensions: { > iso: ['.img', '.iso'], > vztmpl: ['.tar.gz', '.tar.xz', '.tar.zst'], > + 'import': ['ova'], > }, > > cbindData: function(initialConfig) { > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel