From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.gruenbichler@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D978396CC3 for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 14:25:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BB0801AC46 for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 14:25:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 14:25:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8A5A745025; Tue, 16 Apr 2024 14:25:40 +0200 (CEST) Date: Tue, 16 Apr 2024 14:25:36 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: Daniel Krambrock <krambrock@hrz.uni-marburg.de> References: <mailman.427.1713254851.450.pve-devel@lists.proxmox.com> <d6da05811de7ab44350441559e386894de5f62dc.camel@proxmox.com> In-Reply-To: <d6da05811de7ab44350441559e386894de5f62dc.camel@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1713270292.xh2iqeiltv.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.345 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH v2 access-control] fix #5335: stable sorting in user.cfg X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 16 Apr 2024 12:25:41 -0000 with T-B added, thanks! PVE::AccessControl would benefit from a code style cleanup in general, it's one of the more older modules with lots of "old style" code around.. On April 16, 2024 12:53 pm, Folke Gleumes wrote: > Hi, >=20 > thanks for your contribution! >=20 > Looks fine to me. The saving function itself already sorts everything > else, so this should be the last point where it can be indeterministic. >=20 > While at it, could you update the foreach to a for? Not all code > already agrees with our style guide, but we try to update it whenever > we are touching it [0]. >=20 > If you haven't done so already, you need to agree to the Harmony CLI > before we can accept your contribution [1]. >=20 > Gave it a spin and ran some configurations, so you can consider this: > Tested-by: Folke Gleumes <f.gleumes@proxmox.com> >=20 > [0] https://pve.proxmox.com/wiki/Perl_Style_Guide > [1] > https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and= _Copyright >=20 > On Tue, 2024-04-16 at 09:27 +0200, Daniel Krambrock via pve-devel > wrote: >> _______________________________________________ >> pve-devel mailing list >> pve-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20