From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B9B43963FA for ; Mon, 15 Apr 2024 16:03:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 99497B332 for ; Mon, 15 Apr 2024 16:03:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 15 Apr 2024 16:02:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0BCCD44983 for ; Mon, 15 Apr 2024 16:02:56 +0200 (CEST) Date: Mon, 15 Apr 2024 16:02:47 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240223120339.15726-1-h.laimer@proxmox.com> In-Reply-To: <20240223120339.15726-1-h.laimer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1713189677.1dhitjwiz8.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Apr 2024 14:03:01 -0000 On February 23, 2024 1:03 pm, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- >=20 > came up in enterprise support, and I don't think there is a reason to > not have it in the UI, while having it in the API >=20 > v2: > - use Aaron's improved help text >=20 > www/manager6/storage/DirEdit.js | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEd= it.js > index 3e2025fc..4d1921dc 100644 > --- a/www/manager6/storage/DirEdit.js > +++ b/www/manager6/storage/DirEdit.js > @@ -37,6 +37,18 @@ Ext.define('PVE.storage.DirInputPanel', { > }, > ]; > =20 > + me.advancedColumn2 =3D [ > + { > + xtype: 'proxmoxcheckbox', this isn't a boolean value though, but a string that has a special interpretation when its value is a boolean.. this would need at least read-only support for the "contains a path" case, else it breaks the config entry (resetting to it not being treated as mountpoint!) when doing unrelated edits via the UI.. > + name: 'is_mountpoint', > + uncheckedValue: 0, > + fieldLabel: gettext('Mountpoint'), > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext('Enable if something is mounted at this path.= Storage is considered offline as long as nothing is mounted.'), > + }, > + }, > + ]; > me.callParent(); > }, > }); > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20