From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.gruenbichler@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id EC1A09613A
for <pve-devel@lists.proxmox.com>; Mon, 15 Apr 2024 11:36:12 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id C4A0F68BD
for <pve-devel@lists.proxmox.com>; Mon, 15 Apr 2024 11:35:42 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Mon, 15 Apr 2024 11:35:42 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 08DB944A89
for <pve-devel@lists.proxmox.com>; Mon, 15 Apr 2024 11:35:42 +0200 (CEST)
Date: Mon, 15 Apr 2024 11:35:38 +0200
From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20240410131316.1208679-1-f.gruenbichler@proxmox.com>
<20240410131316.1208679-9-f.gruenbichler@proxmox.com>
<1712820202.g97tka6mqx.astroid@yuna.none>
<quyhbmovjhavwrqraywntwpzqdlrf5dfk6lridtaogfhs2svxh@khc2mkber7gg>
In-Reply-To: <quyhbmovjhavwrqraywntwpzqdlrf5dfk6lridtaogfhs2svxh@khc2mkber7gg>
MIME-Version: 1.0
User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid)
Message-Id: <1713173535.lxgai2mb48.astroid@yuna.none>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.056 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH container 7/7] update: handle pool limits
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 15 Apr 2024 09:36:13 -0000
On April 11, 2024 12:03 pm, Wolfgang Bumiller wrote:
> On Thu, Apr 11, 2024 at 09:23:53AM +0200, Fabian Gr=C3=BCnbichler wrote:
>> On April 10, 2024 3:13 pm, Fabian Gr=C3=BCnbichler wrote:
>> > Signed-off-by: Fabian Gr=C3=BCnbichler <f.gruenbichler@proxmox.com>
>> > ---
>> > src/PVE/API2/LXC/Config.pm | 21 +++++++++++++++++++++
>> > 1 file changed, 21 insertions(+)
>> >=20
>> > diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm
>> > index e6c0980..3fb3885 100644
>> > --- a/src/PVE/API2/LXC/Config.pm
>> > +++ b/src/PVE/API2/LXC/Config.pm
>> > @@ -208,6 +208,27 @@ __PACKAGE__->register_method({
>> > =20
>> > my $running =3D PVE::LXC::check_running($vmid);
>> > =20
>> > + my $usage =3D PVE::LXC::Config->get_pool_usage($conf);
>> > + if (defined($param->{memory}) || defined($param->{swap})) {
>> > + my $old =3D $usage->{mem};
>> > + my $new =3D $param->{memory} || $usage->{memory};
>> > + $new *=3D ($param->{swap} || $usage->{swap});
>>=20
>> as Dominik pointed out off-list, this should be an addition, not a
>> multiplication..
>=20
> Do we even want to mix mem & swap? Feels cgroupv1-y... (as in bad)
well, we want a single value (because both VMs and CTs count against the
pool limit, so counting swap separately doesn't make much sense..). I
guess we could either ignore swap altogether (assuming v2), or
conditionalize based on current cgroup mode?