From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1518395018 for ; Thu, 11 Apr 2024 16:22:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EABF532B76 for ; Thu, 11 Apr 2024 16:21:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 11 Apr 2024 16:21:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 08D4944611 for ; Thu, 11 Apr 2024 16:21:52 +0200 (CEST) Date: Thu, 11 Apr 2024 16:21:48 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240229104104.111188-1-s.hanreich@proxmox.com> In-Reply-To: <20240229104104.111188-1-s.hanreich@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1712845023.55m9ezau3w.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, inotify.pm, firewallsimulator.pm] Subject: Re: [pve-devel] [PATCH v3 common/docs/widget-toolkit/manager/firewall 0/6] drop vmbr prefix for bridges X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2024 14:22:23 -0000 Reviewed-by: Fabian Gr=C3=BCnbichler with some small nits for the docs patch, see comment there. the pve-common patch should probably get the bug number (545) in the subject as well. some hint about the inter-dependencies of the patches would be nice, AFAIU: - pve-manager requires proxmox-widget-toolkit - the UI changes require pve-common, but since that is cluster-wide, a dep there only helps the local node as usual (still, it might be a good idea so at least that combo is covered for sure ;)) - the firewall change is rather independent, since it's just the simulator that is affected at worst it won't handle a new interface name. I think this one would make quite a few users happy (at least those that haven't yet switched to SDN with its more flexible naming scheme ;)) On February 29, 2024 11:40 am, Stefan Hanreich wrote: > Original patch series by Jillian Morgan >=20 > I've refrained from adding arbitrary bond names in this patch series, sin= ce > that would require a bigger amount of changes in the firewall simulator. = I'll > look into adding that in a future patch series. >=20 > Changes from v2 -> v3: > * limit bridge names to 10 characters in Web UI > * introduce common variable for bridge names in firewall simulator > * update docs to reflect changes > * add warning for interfaces named vmbrX that are not bridges >=20 > Changes from v1 -> v2: > * limit name to 15 characters > * properly validate bridge names in vlan/qinq zones > * properly handle OVS bridges > * handle new bridge names in firewall simulator >=20 >=20 >=20 > common: >=20 > Stefan Hanreich (1): > interfaces: allow arbitrary bridge names in network config >=20 > src/PVE/INotify.pm | 28 +++++++++++++++------------- > 1 file changed, 15 insertions(+), 13 deletions(-) >=20 >=20 > docs: >=20 > Stefan Hanreich (1): > network: update specification for bridge names >=20 > pve-network.adoc | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) >=20 >=20 > widget-toolkit: >=20 > Stefan Hanreich (1): > network: allow bridges to have any valid interface name >=20 > src/Toolkit.js | 4 ++-- > src/node/NetworkEdit.js | 4 +++- > 2 files changed, 5 insertions(+), 3 deletions(-) >=20 >=20 > manager: >=20 > Stefan Hanreich (2): > sdn: qinq: vlan: properly validate bridge name > sdn: vlan: fix indentation in vlan edit dialogue >=20 > www/manager6/sdn/zones/QinQEdit.js | 3 +++ > www/manager6/sdn/zones/VlanEdit.js | 11 +++++++---- > 2 files changed, 10 insertions(+), 4 deletions(-) >=20 >=20 > firewall: >=20 > Stefan Hanreich (1): > simulator: use new bridge naming scheme >=20 > src/PVE/FirewallSimulator.pm | 29 +++++++++++++++++++---------- > src/PVE/Service/pve_firewall.pm | 5 +++-- > 2 files changed, 22 insertions(+), 12 deletions(-) >=20 >=20 > Summary over all repositories: > 8 files changed, 61 insertions(+), 38 deletions(-) >=20 > --=20 > murpp v0.4.0 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20