From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 51D7A94F9E for ; Thu, 11 Apr 2024 15:45:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2DFE1324A5 for ; Thu, 11 Apr 2024 15:44:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 11 Apr 2024 15:44:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3C4F54428C for ; Thu, 11 Apr 2024 15:44:50 +0200 (CEST) Date: Thu, 11 Apr 2024 15:44:46 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240223104843.34281-1-f.schauer@proxmox.com> In-Reply-To: <20240223104843.34281-1-f.schauer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1712842611.s1gygot5w7.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.193 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, lxc.pm] Subject: Re: [pve-devel] [PATCH v2 container] fix #4846: Avoid the outdated noacl mount option on ext4 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2024 13:45:21 -0000 On February 23, 2024 11:48 am, Filip Schauer wrote: > Do not use the 'noacl' mount option when mounting a container disk with > an ext4 file system. The option was removed from the kernel in commit > 2d544ec923db >=20 > The ext4 detection is based on $do_format in alloc_disk. >=20 > Signed-off-by: Filip Schauer > --- > src/PVE/LXC.pm | 22 ++++++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) >=20 > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index 7883cfb..6810601 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -1835,8 +1835,26 @@ sub __mountpoint_mount { > } > =20 > my $acl =3D $mountpoint->{acl}; > - if (defined($acl)) { > - push @$optlist, ($acl ? 'acl' : 'noacl'); > + > + if ($acl) { > + push @$optlist, 'acl'; > + } else { > + my $noacl =3D 1; > + > + if ($storage) { > + my $scfg =3D PVE::Storage::storage_config($storage_cfg, $storage); > + > + # Avoid the outdated 'noacl' mount option on ext4 file systems > + if ($scfg->{content}->{rootdir} && $scfg->{path}) { > + $noacl =3D ($scfg->{type} eq 'btrfs' && $scfg->{quotas}); I am not sure this is correct.. or rather, wouldn't it be simpler to say if $storage && $format eq 'raw' =3D> no noacl ? if we get complains that somebody did something non-standard (i.e., manually formatted a raw volume using a different filesystem), we can always think about adding support for that (e.g., via some "fs=3DXX" property on the mountpoint that allows us to handle it here, although I am not even sure if we *want* to support that ;)). > + } elsif ($scfg->{type} eq 'zfspool') { > + $noacl =3D 1; > + } elsif ($scfg->{content}->{rootdir}) { > + $noacl =3D 0; > + } > + } > + > + push @$optlist, 'noacl' if $noacl; > } > =20 > my $optstring =3D join(',', @$optlist); > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20