From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F21A394F85 for ; Thu, 11 Apr 2024 15:29:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CAC1532182 for ; Thu, 11 Apr 2024 15:29:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 11 Apr 2024 15:29:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D31AE44283 for ; Thu, 11 Apr 2024 15:29:21 +0200 (CEST) Date: Thu, 11 Apr 2024 15:29:18 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20231205113532.58166-1-f.ebner@proxmox.com> In-Reply-To: <20231205113532.58166-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1712842150.sbdhvwxkfd.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm, proxmox.com] Subject: [pve-devel] applied: [PATCH container] config list helper: fix return type of vmid for container index API enpoint X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2024 13:29:53 -0000 On December 5, 2023 12:35 pm, Fiona Ebner wrote: > The schema declares it to be an integer. Done in the config_list() > helper, to ensure consistency for the following existing code in > vmstatus(): >=20 >> my $list =3D $opt_vmid ? { $opt_vmid =3D> { type =3D> 'lxc', vmid =3D> i= nt($opt_vmid) }} : config_list(); >=20 > Should not cause any issues for other callers of the helper. >=20 > Reported in the community forum: > https://forum.proxmox.com/threads/137628/ >=20 > Signed-off-by: Fiona Ebner > --- > src/PVE/LXC.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index 7883cfb..4fb4ef2 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -69,7 +69,7 @@ sub config_list { > my $d =3D $ids->{$vmid}; > next if !$d->{node} || $d->{node} ne $nodename; > next if !$d->{type} || $d->{type} ne 'lxc'; > - $res->{$vmid} =3D { type =3D> 'lxc', vmid =3D> $vmid }; > + $res->{$vmid} =3D { type =3D> 'lxc', vmid =3D> int($vmid) }; > } > return $res; > } > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20