From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 028B394A34 for ; Thu, 11 Apr 2024 09:23:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DF97B1B465 for ; Thu, 11 Apr 2024 09:23:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 11 Apr 2024 09:23:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A7A1143628 for ; Thu, 11 Apr 2024 09:23:57 +0200 (CEST) Date: Thu, 11 Apr 2024 09:23:53 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240410131316.1208679-1-f.gruenbichler@proxmox.com> <20240410131316.1208679-9-f.gruenbichler@proxmox.com> In-Reply-To: <20240410131316.1208679-9-f.gruenbichler@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1712820202.g97tka6mqx.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH container 7/7] update: handle pool limits X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2024 07:23:59 -0000 On April 10, 2024 3:13 pm, Fabian Gr=C3=BCnbichler wrote: > Signed-off-by: Fabian Gr=C3=BCnbichler > --- > src/PVE/API2/LXC/Config.pm | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) >=20 > diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm > index e6c0980..3fb3885 100644 > --- a/src/PVE/API2/LXC/Config.pm > +++ b/src/PVE/API2/LXC/Config.pm > @@ -208,6 +208,27 @@ __PACKAGE__->register_method({ > =20 > my $running =3D PVE::LXC::check_running($vmid); > =20 > + my $usage =3D PVE::LXC::Config->get_pool_usage($conf); > + if (defined($param->{memory}) || defined($param->{swap})) { > + my $old =3D $usage->{mem}; > + my $new =3D $param->{memory} || $usage->{memory}; > + $new *=3D ($param->{swap} || $usage->{swap}); as Dominik pointed out off-list, this should be an addition, not a multiplication.. > + > + if ($new > $old) { > + my $change =3D { mem =3D> ($new - $old) * 1024 * 1024 }; > + PVE::GuestHelpers::check_guest_pool_limit($vmid, $change); > + } > + } > + if (defined($param->{cores})) { > + my $old =3D $usage->{cpu}; > + my $new =3D $param->{cores}; > + > + if ($new > $old) { > + my $change =3D { cpu =3D> ($new - $old) }; > + PVE::GuestHelpers::check_guest_pool_limit($vmid, $change); > + } > + } > + > my $errors =3D PVE::LXC::Config->update_pct_config($vmid, $conf, $r= unning, $param, \@delete, \@revert); > PVE::LXC::Config->write_config($vmid, $conf); > $conf =3D PVE::LXC::Config->load_config($vmid); > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20