From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C03F690A7D for ; Mon, 12 Feb 2024 14:33:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A980E19CF8 for ; Mon, 12 Feb 2024 14:33:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 12 Feb 2024 14:33:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DF86E478E2 for ; Mon, 12 Feb 2024 14:33:52 +0100 (CET) Date: Mon, 12 Feb 2024 14:33:45 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240205175419.1271680-1-m.carrara@proxmox.com> <20240205175419.1271680-8-m.carrara@proxmox.com> In-Reply-To: <20240205175419.1271680-8-m.carrara@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1707742887.vpjp8ojapl.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 pve-storage 07/11] amend! cephconfig: allow writing arbitrary sections X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2024 13:33:54 -0000 On February 5, 2024 6:54 pm, Max Carrara wrote: > cephconfig: allow writing arbitrary sections >=20 > This adds support for writing arbitrary sections to 'ceph.conf' while > ensuring that already written sections are not duplicated. >=20 > Sections that are associated with the client, for example > '[client.foo]', are written directly after the '[client]' section. >=20 > Sections associated with 'mds', 'mon', 'osd' and 'mgr' are also > written directly after their associated section. >=20 > Signed-off-by: Max Carrara > --- > NOTE: This amend really just changes the order of the sections below and > may be dropped if not desired. does the order matter at all? the docs would imply that it doesn't, since there is a clear precedence between [global], [$type], and [$type.$id] (e.g., global -> client -> client.crash).. https://docs.ceph.com/en/latest/rados/configuration/ceph-conf/#configuratio= n-sections >=20 > Changes v1 --> v2: > * new >=20 > src/PVE/CephConfig.pm | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) >=20 > diff --git a/src/PVE/CephConfig.pm b/src/PVE/CephConfig.pm > index 86d3079..00b1f35 100644 > --- a/src/PVE/CephConfig.pm > +++ b/src/PVE/CephConfig.pm > @@ -82,17 +82,20 @@ sub write_ceph_config { > }; > =20 > &$cond_write_sec('global'); > + > &$cond_write_sec('client'); > &$cond_write_sec('client\..*'); > =20 > &$cond_write_sec('mds'); > - &$cond_write_sec('mon'); > - &$cond_write_sec('osd'); > - &$cond_write_sec('mgr'); > - > &$cond_write_sec('mds\..*'); > + > + &$cond_write_sec('mon'); > &$cond_write_sec('mon\..*'); > + > + &$cond_write_sec('osd'); > &$cond_write_sec('osd\..*'); > + > + &$cond_write_sec('mgr'); > &$cond_write_sec('mgr\..*'); > =20 > &$cond_write_sec('.*'); > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20