From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 878A890A6E for ; Mon, 12 Feb 2024 14:33:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 671F119C80 for ; Mon, 12 Feb 2024 14:33:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 12 Feb 2024 14:33:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8F312478D5 for ; Mon, 12 Feb 2024 14:33:17 +0100 (CET) Date: Mon, 12 Feb 2024 14:33:11 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240205175419.1271680-1-m.carrara@proxmox.com> <20240205175419.1271680-5-m.carrara@proxmox.com> In-Reply-To: <20240205175419.1271680-5-m.carrara@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1707741504.hpouq8024x.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 quincy-stable-8 ceph 04/11] patches: add patch that reorders clients used by ceph-crash X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2024 13:33:48 -0000 On February 5, 2024 6:54 pm, Max Carrara wrote: > This patch makes it so that `ceph-crash` attempts to use the > non-host-specific keyring before anything else, which avoids > unnecessary error messages landing in the systemd-journal in our case. >=20 > Signed-off-by: Max Carrara Reviewed-by: Fabian Gr=C3=BCnbichler > --- > Changes v1 --> v2: > * new >=20 > ...h-crash-change-order-of-client-names.patch | 30 +++++++++++++++++++ > patches/series | 1 + > 2 files changed, 31 insertions(+) > create mode 100644 patches/0025-ceph-crash-change-order-of-client-names.= patch >=20 > diff --git a/patches/0025-ceph-crash-change-order-of-client-names.patch b= /patches/0025-ceph-crash-change-order-of-client-names.patch > new file mode 100644 > index 000000000..cc0bdccdb > --- /dev/null > +++ b/patches/0025-ceph-crash-change-order-of-client-names.patch > @@ -0,0 +1,30 @@ > +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 > +From: Max Carrara > +Date: Mon, 5 Feb 2024 11:44:14 +0100 > +Subject: [PATCH] ceph-crash: change order of client names > + > +This simply puts 'client.crash' before 'client.crash.${HOSTNAME}'. > + > +Signed-off-by: Max Carrara > +--- > + src/ceph-crash.in | 4 ++-- > + 1 file changed, 2 insertions(+), 2 deletions(-) > + > +diff --git a/src/ceph-crash.in b/src/ceph-crash.in > +index 010d6ea2e82..d1d9f4123e6 100755 > +--- a/src/ceph-crash.in > ++++ b/src/ceph-crash.in > +@@ -16,8 +16,8 @@ import time > + logging.basicConfig(level=3Dlogging.INFO) > + log =3D logging.getLogger('ceph-crash') > +=20 > +-auth_names =3D ['client.crash.%s' % socket.gethostname(), > +- 'client.crash', > ++auth_names =3D ['client.crash', > ++ 'client.crash.%s' % socket.gethostname(), > + 'client.admin'] > +=20 > +=20 > +--=20 > +2.39.2 > + > diff --git a/patches/series b/patches/series > index 34185c7da..8160de645 100644 > --- a/patches/series > +++ b/patches/series > @@ -17,3 +17,4 @@ > 0022-mgr-dashboard-remove-ability-to-create-and-check-TLS.patch > 0023-rocksb-inherit-parent-cmake-cxx-flags.patch > 0024-debian-adjust-permissions-of-subdirectories-of-var-l.patch > +0025-ceph-crash-change-order-of-client-names.patch > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20