From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DFA8291CDA for ; Wed, 31 Jan 2024 12:35:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BD61439E61 for ; Wed, 31 Jan 2024 12:34:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 31 Jan 2024 12:34:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C71634936C for ; Wed, 31 Jan 2024 12:34:45 +0100 (CET) Date: Wed, 31 Jan 2024 12:34:38 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240131105400.19813-1-f.ebner@proxmox.com> In-Reply-To: <20240131105400.19813-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1706700870.hhqx404h2g.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -1.334 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SCC_BODY_URI_ONLY 2.796 - SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemu.pm, proxmox.com] Subject: [pve-devel] applied: [PATCH qemu-server] api: fix using import-from with SCSI disks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2024 11:35:16 -0000 On January 31, 2024 11:53 am, Fiona Ebner wrote: > by fixing the SCSI feature compatibility check helper. The helper is > also called for disks using import-from, so it has to use the extended > schema when parsing the drive. >=20 > Fixes: d1feab4a ("fix #4957: add vendor and product information passthrou= gh for SCSI-Disks") > Signed-off-by: Fiona Ebner > --- > PVE/API2/Qemu.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index cdc8f7ac..69c5896a 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -699,7 +699,7 @@ my $check_vm_modify_config_perm =3D sub { > sub assert_scsi_feature_compatibility { > my ($opt, $conf, $storecfg, $drive_attributes) =3D @_; > =20 > - my $drive =3D PVE::QemuServer::Drive::parse_drive($opt, $drive_attri= butes); > + my $drive =3D PVE::QemuServer::Drive::parse_drive($opt, $drive_attri= butes, 1); > =20 > my $machine_type =3D PVE::QemuServer::get_vm_machine($conf, undef, $= conf->{arch}); > my $machine_version =3D PVE::QemuServer::Machine::extract_version( > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20